Don't duplicate invalidate local call on get event cache

matrix-org · Jul 14, 2022 · ec33b99 · ec33b99
1 parent 037d84f
commit ec33b99
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/synapse/storage/databases/main/events_worker.py b/synapse/storage/databases/main/events_worker.py
@@ -733,7 +733,8 @@ async def get_missing_events_from_db() -> Dict[str, EventCacheEntry]:
 
  async def _invalidate_get_event_cache(self, event_id: str) -> None:
  await self._get_event_cache.invalidate((event_id,))
- self._invalidate_local_get_event_cache(event_id)
+ self._event_ref.pop(event_id, None)
+ self._current_event_fetches.pop(event_id, None)
 
  def _invalidate_local_get_event_cache(self, event_id: str) -> None:
  self._get_event_cache.invalidate_local((event_id,))