Add correct M_BAD_JSON error code to /profile/{userId}/displayname (#…

…8517) Fixes #8029
matrix-org · Oct 14, 2020 · ec606ea · ec606ea
1 parent 629a951
commit ec606ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/8517.bugfix b/changelog.d/8517.bugfix
@@ -0,0 +1 @@
+Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`.
diff --git a/synapse/rest/client/v1/profile.py b/synapse/rest/client/v1/profile.py
@@ -59,7 +59,9 @@ async def on_PUT(self, request, user_id):
         try:
             new_name = content["displayname"]
         except Exception:
-            return 400, "Unable to parse name"
+            raise SynapseError(
+                code=400, msg="Unable to parse name", errcode=Codes.BAD_JSON,
+            )
 
         await self.profile_handler.set_displayname(user, requester, new_name, is_admin)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`.