Fix outbound federation request metrics (#6795)

matrix-org · Jan 28, 2020 · fcfb591 · fcfb591
1 parent cc109b7
commit fcfb591
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/changelog.d/6795.bugfix b/changelog.d/6795.bugfix
@@ -0,0 +1 @@
+Fix outbound federation request metrics.
diff --git a/synapse/http/matrixfederationclient.py b/synapse/http/matrixfederationclient.py
@@ -408,6 +408,8 @@ def _send_request(
  _sec_timeout,
  )
 
+ outgoing_requests_counter.labels(method_bytes).inc()
+
  try:
  with Measure(self.clock, "outbound_request"):
  # we don't want all the fancy cookie and redirect handling
@@ -440,6 +442,8 @@ def _send_request(
  response.phrase.decode("ascii", errors="replace"),
  )
 
+ incoming_responses_counter.labels(method_bytes, response.code).inc()
+
  set_tag(tags.HTTP_STATUS_CODE, response.code)
 
  if 200 <= response.code < 300: