This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
_count_known_servers delay #10030
Comments
@heftig You're correct, and that definitely shouldn't be 1,000 seconds 🙂 Would you like to PR a fix? Otherwise we can take care of it. |
anoadragon453
added
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
labels
May 26, 2021
I would if I just had to make a commit with the fix, but your guidelines require a lot more work I don't have time for. |
Understandable, thanks for bringing it to our attention regardless 🙂 I've opened a PR to fix this here: #10195 |
anoadragon453
added a commit
that referenced
this issue
Jun 17, 2021
Fixes #10030. We were expecting milliseconds where we should have provided a value in seconds. The impact of this bug isn't too bad. The code is intended to count the number of remote servers that the homeserver can see and report that as a metric. This metric is supposed to run initially 1 second after server startup, and every 60s as well. Instead, it ran 1,000 seconds after server startup, and every 60s after startup. This fix allows for the correct metrics to be collected immediately, as well as preventing a random collection 1,000s in the future after startup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
synapse/synapse/storage/databases/main/roommember.py
Lines 88 to 95 in 1c6a190
Is this really supposed to be 1000 seconds?
looping_call
uses milliseconds andcall_later
uses seconds.The text was updated successfully, but these errors were encountered: