Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Olddeps job is running against Python 3.8, but our oldest supported is 3.7 #12343

Closed
DMRobertson opened this issue Mar 31, 2022 · 4 comments · Fixed by #13707
Closed

Olddeps job is running against Python 3.8, but our oldest supported is 3.7 #12343

DMRobertson opened this issue Mar 31, 2022 · 4 comments · Fixed by #13707
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

At the time of writing we use the system version of python3 that's provided by Ubuntu focal, which is 3.8.

@DMRobertson DMRobertson added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Mar 31, 2022
@DMRobertson
Copy link
Contributor Author

Is there any particular reason that olddeps is tied to a particular Debian/Ubuntu distribution? What's there to stop us from using actions/setup-python with version: 3.7? I guess we wouldn't have older libcs...

Oh, it's the old postgres version we want. Hmm.

@richvdh
Copy link
Member

richvdh commented Apr 5, 2022

for context, this change happened in #12343. It's not obvious to me if we realised that this would bring Python 3.8 at the time.

That said, we do have separate test runs for Python 3.7, so it's not necessarily a large problem.

@richvdh
Copy link
Member

richvdh commented Apr 5, 2022

Oh, it's the old postgres version we want. Hmm.

I'm not sure it is. We have a separate test job for python 3.7 and postgres 10.

@DMRobertson DMRobertson linked a pull request Sep 6, 2022 that will close this issue
@DMRobertson
Copy link
Contributor Author

Fixed as a drive-by in #13707, thanks Erik!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants