Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Admin list-room API returns integers instead of booleans on SQLite #13505

Closed
jplatte opened this issue Aug 11, 2022 · 3 comments · Fixed by #13509
Closed

Admin list-room API returns integers instead of booleans on SQLite #13505

jplatte opened this issue Aug 11, 2022 · 3 comments · Fixed by #13509
Labels
A-Admin-API O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@jplatte
Copy link
Contributor

jplatte commented Aug 11, 2022

Description

According to ruma/synapse-admin-api#14, the federatable and public fields in the response of the List room API return 0 / 1 instead of true / false, while the example in the linked documentation shows boolean values.

Steps to reproduce

Use the list room API? 🤷🏼

Homeserver

any

Synapse Version

unknown

Installation Method

No response

Platform

unknown

Relevant log output

-

Anything else that would be useful to know?

No response

@DMRobertson
Copy link
Contributor

Is the server you are querying using a sqlite database rather than postgres?

@jplatte
Copy link
Contributor Author

jplatte commented Aug 11, 2022

I haven't reproduced this myself, just carried over the bug report in ruma/synapse-admin-api#14. @avp90 can you answer?

@DMRobertson DMRobertson added A-Admin-API T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches labels Aug 11, 2022
@avp90
Copy link

avp90 commented Aug 11, 2022

Yes in my test case it's a SQLite database.

DMRobertson pushed a commit that referenced this issue Aug 11, 2022
@richvdh richvdh changed the title Admin API documentation seems inconsistent with implementation Admin list-room API returns integers instead of booleans on SQLite Aug 24, 2022
@richvdh richvdh added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. and removed P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches labels Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Admin-API O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants