This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Generalize tracking whenever we fail to fetch or process a federated event #13700
Open
2 of 9 tasks
Tracked by
#15182
Labels
A-Federation
A-Messages-Endpoint
/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Comments
MadLittleMods
added
the
A-Messages-Endpoint
/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)
label
Sep 1, 2022
5 tasks
11 tasks
squahtx
added
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
labels
Sep 2, 2022
MadLittleMods
added a commit
that referenced
this issue
Sep 14, 2022
We can follow-up this PR with: 1. Only try to backfill from an event if we haven't tried recently -> #13622 1. When we decide to backfill that event again, process it in the background so it doesn't block and make `/messages` slow when we know it will probably fail again -> #13623 1. Generally track failures everywhere we try and fail to pull an event over federation -> #13700 Fix #13621 Part of #13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.qv7cj51sv9i5)
4 tasks
MadLittleMods
added a commit
that referenced
this issue
Sep 14, 2022
4 tasks
MadLittleMods
added a commit
that referenced
this issue
Sep 15, 2022
MadLittleMods
added a commit
that referenced
this issue
Oct 3, 2022
Because we're doing the recording in `_check_sigs_and_hash_for_pulled_events_and_fetch` (previously named `_check_sigs_and_hash_and_fetch`), this means we will track signature failures for `backfill`, `get_room_state`, `get_event_auth`, and `get_missing_events` (all pulled event scenarios). And we also record signature failures from `get_pdu`. Part of #13700 Part of #13676 and #13356 This PR will be especially important for #13816 so we can avoid the costly `_get_state_ids_after_missing_prev_event` down the line when `/messages` calls backfill.
7 tasks
8 tasks
Open
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Federation
A-Messages-Endpoint
/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Follow-up to #13621. As discussed at #13589 (comment) and #13589 (comment)
Maybe: Track when we ask/backfill
from a certain event but the/backfill
response doesn't include it_check_sigs_and_hash_and_fetch_one
,Signature on retrieved event was invalid
)/event/{eventId}
/event_auth/{roomId}/{eventId}
/state/{roomId}?event_id=$xxx
/state_ids/{roomId}?event_id=$xxx
/get_missing_events
_check_sigs_and_hash_and_fetch
to trace time spent in child concurrent calls #13588 (comment)We will need to add more
record_event_failed_backfill_attempt
calls for the failed to fetch scenarios though.The text was updated successfully, but these errors were encountered: