Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

poetry install seems to build Rust crate in debug mode #13990

Closed
erikjohnston opened this issue Sep 30, 2022 · 3 comments · Fixed by #14009
Closed

poetry install seems to build Rust crate in debug mode #13990

erikjohnston opened this issue Sep 30, 2022 · 3 comments · Fixed by #14009
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release

Comments

@erikjohnston
Copy link
Member

erikjohnston commented Sep 30, 2022 •
edited
Loading

We should build it in release mode for packages, at the very least.

I think wheels are correctly built in release mode
@erikjohnston erikjohnston added the X-Release-Blocker Must be resolved before making a release label Sep 30, 2022
@erikjohnston
Copy link
Member Author

I think we should just set debug=True in build_rust.py to force poetry install to always build in release mode. The default behaviour is to use debug for "inplace" builds (which is what poetry install does) and otherwise "release" (so poetry build would be fine).

@DMRobertson DMRobertson added A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Sep 30, 2022
@DMRobertson
Copy link
Contributor

think we should just set debug=True in build_rust.py to force poetry install to always build in release mode.

Err, should this be debug=False?

@erikjohnston
Copy link
Member Author

Yes 🤦

erikjohnston added a commit that referenced this issue Oct 3, 2022
@erikjohnston
Always build Rust extension in release mode
b494ac3 
Fixes #13990
@erikjohnston erikjohnston mentioned this issue Oct 3, 2022
Merged
erikjohnston added a commit that referenced this issue Oct 3, 2022
@erikjohnston
Always build Rust extension in release mode (#14009)
343038c 
Fixes #13990
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always build Rust extension in release mode matrix-org/synapse
2 participants
@erikjohnston @DMRobertson