Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

missing auth_events can break federation within a room #3330

Closed
ara4n opened this issue Jun 3, 2018 · 1 comment
Closed

missing auth_events can break federation within a room #3330

ara4n opened this issue Jun 3, 2018 · 1 comment
Assignees
@erikjohnston
Labels
Security z-bug (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Jun 3, 2018

if the synapse ends up trying to query servers that don't implement /event_auth, or perhaps doesn't try multiple servers, then it can get stuck trying to accept an otherwise legitimate event because it refers to an auth event it can't resolve
@ara4n
Copy link
Member Author

ara4n commented Jun 3, 2018

https://matrix.to/#/#synapse-dev:matrix.org/$Wdf7p4eSYFnsRosSLtq72FcFjgkNmyLHUPAQZ2T1x7c:zemos.net for more details.

@ara4n ara4n added p1 z-bug (Deprecated Label) labels Jun 3, 2018
@richvdh richvdh added the r0 P1 label Jan 7, 2019
@neilisfragile neilisfragile removed the v1.0 label Jan 8, 2019
@neilisfragile neilisfragile added v1.0 and removed r0 P1 labels Jan 24, 2019
erikjohnston added a commit that referenced this issue Jun 3, 2019
@erikjohnston
Fix handling of failures when calling /event_auth.
220a733 
When processing an incoming event over federation, we may try and
resolve any unexpected differences in auth events. This is a
non-essential process and so should not stop the processing of the event
if it fails (e.g. due to the remote disappearing or not implementing the
necessary endpoints).

Fixes #3330
@erikjohnston erikjohnston mentioned this issue Jun 3, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erikjohnston erikjohnston

Labels
Security z-bug (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@callahad @neilisfragile @ara4n @richvdh @erikjohnston