Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Room version upgrade undocumented #5709

Closed
4b69 opened this issue Jul 17, 2019 · 16 comments
Closed

Room version upgrade undocumented #5709

4b69 opened this issue Jul 17, 2019 · 16 comments
Labels
A-Docs things relating to the documentation z-p3 (Deprecated Label)

Comments

@4b69
Copy link

4b69 commented Jul 17, 2019

There is currently no documented way to upgrade a room version (typically 1 -> 4 as of writing) which is the new default room version for synapse. This ideally should be in the upgrade notes for Synapse.

@richvdh
Copy link
Member

richvdh commented Jul 18, 2019

The upgrade call is part of the Client-Server API: https://matrix.org/docs/spec/client_server/r0.5.0#id205

@neilisfragile
Copy link
Contributor

At this point we are not actively encouraging mods to upgrade their rooms unless they specifically need to (generally only applies to large public rooms).

Rationale is that we are still ironing out some bugs in the upgrade process and we expect further room versions.

@neilisfragile neilisfragile added z-p3 (Deprecated Label) A-Docs things relating to the documentation labels Jul 19, 2019
@PC-Admin
Copy link

an idiot proof version would be appreciated x)

@4b69
Copy link
Author

4b69 commented Jul 21, 2019

For what it's worth for others reading, I found this purely by chance; you can do /upgraderoom 4 in riot-web to upgrade a room...

@PC-Admin
Copy link

@nja0087 you the real MVP here

@bbigras
Copy link
Contributor

bbigras commented May 28, 2020

You'll also find support for rooms v6. v6 contains some small but important changes to improve the security of the room model. As with all room version upgrades we can't switch to v6 as the default version immediately since we need to build up a critical mass of servers that can support it. So upgrade and watch this space for when we switch over properly.

https://matrix.org/blog/2020/05/28/synapse-1-14-0-released

Is it highly recommended upgrading every room?

Does the upgrade create a new room? Will the history be lost?

If it's recommended for security reasons maybe it could be nice to have a warning in riot-web.

@squarepupil
Copy link

squarepupil commented Aug 28, 2020

Does the upgrade create a new room? Will the history be lost?

I just tested upgrading a room from version 4 to 6 and it did indeed create a new room without the history from the previous room. You get a link at the start of the conversation in that room to see the history from the old room.

@ChristianTacke
Copy link

It would be nice, if the new room could be populated with the old history. So that the new room has the full history.
As one server does the creation of the new room, it should be able to prepopulate the history?

@rubo77
Copy link
Contributor

rubo77 commented Mar 10, 2021

It would be nice, if the new room could be populated with the old history. So that the new room has the full history.

I really appreciate this too. But it should be optional

@richvdh
Copy link
Member

richvdh commented Apr 30, 2021

I'm not sure this needs further documentation on the synapse side right now

@richvdh richvdh closed this as completed Apr 30, 2021
@ChristianTacke
Copy link

It would be nice, if the new room could be populated with the old history. So that the new room has the full history.

I really appreciate this too. But it should be optional

@rubo77 Any idea where we can post this idea as a Feature Request? Or has it already been done?

@heyakyra
Copy link

heyakyra commented Jul 2, 2021

#5709 (comment)

you can do /upgraderoom 4 in riot-web to upgrade a room...

How can this be done with a custom event in devtools?

@rubo77
Copy link
Contributor

rubo77 commented Jul 3, 2021

It would be nice, if the new room could be populated with the old history. So that the new room has the full history.

I really appreciate this too. But it should be optional

@rubo77 Any idea where we can post this idea as a Feature Request? Or has it already been done?

You should open a new issue here

@heyakyra
Copy link

Can a space be upgraded?

@ChristianTacke
Copy link

Okay, filed a new issue for the history population: element-hq/element-web#10377

@heyakyra
Copy link

heyakyra commented Mar 1, 2023

Ticket for space upgrades element-hq/element-meta#1961

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

9 participants