Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement v2 APIs for send_join and send_leave #6349

Merged
merged 10 commits into from
Dec 11, 2019
Merged

Conversation

babolivier
Copy link
Contributor

Implements MSC1802.

Fix #6293

@babolivier babolivier marked this pull request as ready for review November 11, 2019 16:53
@babolivier babolivier requested a review from a team November 11, 2019 16:53
@babolivier
Copy link
Contributor Author

SyTest tests will come later, in the meantime I suggest having a review on this one then holding off from merging until they're here.

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo needing some tests

@babolivier
Copy link
Contributor Author

babolivier commented Dec 11, 2019

matrix-org/sytest#760 got approved, which tests one half of it. I'll merge both this PR and the SyTest one and work on the /send_leave tests as a next step.

@babolivier babolivier merged commit 54ae52b into develop Dec 11, 2019
@babolivier babolivier deleted the babolivier/msc1802 branch January 9, 2020 15:45
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '54ae52ba9':
  Lint
  Changelog
  Lint
  Fix prefix for v2/send_leave
  Add server-side support to the v2 API
  Implement v2 API for send_leave
  Add missing yield
  Implement v2 API for send_join
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants