Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test v2 endpoint for /send_join #760

Merged
merged 10 commits into from
Dec 11, 2019
Merged

Test v2 endpoint for /send_join #760

merged 10 commits into from
Dec 11, 2019

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Dec 5, 2019

One half of testing the implementation of MSC1802 (matrix-org/synapse#6293). Also adds support for await_request_[...] on non-v1 endpoints.

@babolivier babolivier requested a review from a team December 5, 2019 19:06
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly can we reduce the duplicated code? It makes it harder to fix/change/understand tests otherwise

lib/SyTest/Federation/Server.pm Show resolved Hide resolved
tests/50federation/30room-join.pl Outdated Show resolved Hide resolved
tests/50federation/30room-join.pl Outdated Show resolved Hide resolved
@richvdh
Copy link
Member

richvdh commented Dec 6, 2019

I have some thoughts on this too... bear with me.

richvdh
richvdh previously requested changes Dec 6, 2019
lib/SyTest/Federation/Server.pm Outdated Show resolved Hide resolved
lib/SyTest/Federation/Server.pm Outdated Show resolved Hide resolved
lib/SyTest/Federation/Server.pm Outdated Show resolved Hide resolved
@babolivier babolivier dismissed stale reviews from richvdh and erikjohnston December 9, 2019 17:20

stale

@babolivier babolivier requested a review from a team December 9, 2019 17:20
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, this doesn't look right

tests/50federation/30room-join.pl Outdated Show resolved Hide resolved
@babolivier babolivier requested a review from a team December 10, 2019 16:50
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants