Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

sample config claims that email.smtp_port is optional, which is untrue #6961

Closed
richvdh opened this issue Feb 20, 2020 · 2 comments · Fixed by #6962
Closed

sample config claims that email.smtp_port is optional, which is untrue #6961

richvdh opened this issue Feb 20, 2020 · 2 comments · Fixed by #6962

Comments

@richvdh
Copy link
Member

richvdh commented Feb 20, 2020

No description provided.

@richvdh richvdh mentioned this issue Feb 20, 2020
Closed
@richvdh
Copy link
Member Author

richvdh commented Feb 20, 2020

also introduced in #6685

richvdh added a commit that referenced this issue Feb 20, 2020
@richvdh
Fix minor issues with email config
80f63db 
 * Give `notif_template_html`, `notif_template_text` default values (fixes
   #6960)
 * Don't complain if `smtp_host` and `smtp_port` are unset, since they have
   sensible defaults (fixes #6961)
 * Raise errors as ConfigError rather than RuntimeError for nicer formatting
@richvdh richvdh mentioned this issue Feb 20, 2020
Merged
@richvdh richvdh linked a pull request Feb 20, 2020 that will close this issue
Fix minor issues with email config #6962
Merged
richvdh added a commit that referenced this issue Feb 24, 2020
@richvdh
Fix minor issues with email config (#6962)
4c2ed3f 
 * Give `notif_template_html`, `notif_template_text` default values (fixes #6960)
 * Don't complain if `smtp_host` and `smtp_port` are unset, since they have sensible defaults (fixes #6961)
 * Set the example for `enable_notifs` to `True`, for consistency and because it's more useful
 * Raise errors as ConfigError rather than RuntimeError for nicer formatting
@richvdh
Copy link
Member Author

richvdh commented Feb 24, 2020

fixed by #6962

@richvdh richvdh closed this as completed Feb 24, 2020
phil-flex pushed a commit to phil-flex/synapse that referenced this issue Apr 15, 2020
@richvdh @phil-flex
Fix minor issues with email config (matrix-org#6962)
c1c4a4d 
 * Give `notif_template_html`, `notif_template_text` default values (fixes matrix-org#6960)
 * Don't complain if `smtp_host` and `smtp_port` are unset, since they have sensible defaults (fixes matrix-org#6961)
 * Set the example for `enable_notifs` to `True`, for consistency and because it's more useful
 * Raise errors as ConfigError rather than RuntimeError for nicer formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minor issues with email config matrix-org/synapse
1 participant
@richvdh