Support for MSC2285 (hidden read receipts) #10413

SimonBrandner · 2021-07-16T08:09:21Z

Pull request is based on the develop branch
Pull request includes a changelog file.
Pull request includes a sign off
Code style is correct (run the linters)

Based on #5990
Implementation of matrix-org/matrix-spec-proposals#2285

To be honest, this PR doesn't fill me with feelings of confidence as I don't have much backend and Python development experience 😅 In case it's bad, sorry and feel free to reject it

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

synapse/handlers/receipts.py

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

babolivier

Thanks! Looks sane to me apart from a few things. Also I think we'll probably want to hide this feature behind a flag in the experimental_features config until the MSC merges.

tests/handlers/test_receipts.py

tests/rest/client/v2_alpha/test_sync.py

synapse/handlers/receipts.py

synapse/rest/client/v2_alpha/receipts.py

synapse/rest/client/v2_alpha/read_marker.py

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner · 2021-07-26T15:21:38Z

Thanks for the review and sorry for the mistakes, hopefully, they're resolved now 😅

babolivier

Looks really good now! Just a couple of bits and it should be good to go!

sorry for the mistakes, hopefully, they're resolved now

Absolutely no worries at all, thanks a lot for working on this contribution! 🙂

tests/handlers/test_receipts.py

synapse/handlers/receipts.py

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>

babolivier

(this is the last one I promise)

tests/handlers/test_receipts.py

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

…/synapse into feature/hidden-rrs

babolivier

Looks good to me! I'll just wait for the CI to complete and merge this. Thanks again for your contribution! 😄

changelog.d/10413.feature

Fixes a bug introduced in rc1 that would cause Synapse to 400 on read receipts requests with empty bodies. Broken in #10413

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\matrix-org#10449](matrix-org#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\matrix-org#10449](matrix-org#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\matrix-org#10543](matrix-org#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\matrix-org#10517](matrix-org#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\matrix-org#10531](matrix-org#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\matrix-org#10516](matrix-org#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\matrix-org#9918](matrix-org#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#10245](matrix-org#10245), [\matrix-org#10432](matrix-org#10432), [\matrix-org#10463](matrix-org#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\matrix-org#10254](matrix-org#10254), [\matrix-org#10447](matrix-org#10447), [\matrix-org#10489](matrix-org#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\matrix-org#10283](matrix-org#10283)) - Add a buffered logging handler which periodically flushes itself. ([\matrix-org#10407](matrix-org#10407), [\matrix-org#10515](matrix-org#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\matrix-org#10411](matrix-org#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\matrix-org#10413](matrix-org#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\matrix-org#10426](matrix-org#10426)) - Allow setting transaction limit for database connections. ([\matrix-org#10440](matrix-org#10440), [\matrix-org#10511](matrix-org#10511)) - Add `creation_ts` to "list users" admin API. ([\matrix-org#10448](matrix-org#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\matrix-org#10410](matrix-org#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\matrix-org#10439](matrix-org#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\matrix-org#10455](matrix-org#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\matrix-org#10499](matrix-org#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\matrix-org#10445](matrix-org#10445)) - Consolidate development documentation to `docs/development/`. ([\matrix-org#10453](matrix-org#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\matrix-org#10464](matrix-org#10464)) - Document how to use Complement while developing a new Synapse feature. ([\matrix-org#10483](matrix-org#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\matrix-org#10390](matrix-org#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\matrix-org#10408](matrix-org#10408)) - Remove shebang line from module files. ([\matrix-org#10415](matrix-org#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\matrix-org#10429](matrix-org#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\matrix-org#10431](matrix-org#10431)) - Improve servlet type hints. ([\matrix-org#10437](matrix-org#10437), [\matrix-org#10438](matrix-org#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\matrix-org#10442](matrix-org#10442)) - Update the `tests-done` Github Actions status. ([\matrix-org#10444](matrix-org#10444), [\matrix-org#10512](matrix-org#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\matrix-org#10446](matrix-org#10446), [\matrix-org#10450](matrix-org#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\matrix-org#10451](matrix-org#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\matrix-org#10468](matrix-org#10468)) - Additional type hints in the state handler. ([\matrix-org#10482](matrix-org#10482)) - Update syntax used to run complement tests. ([\matrix-org#10488](matrix-org#10488)) - Fix up type annotations to work with Twisted 21.7. ([\matrix-org#10490](matrix-org#10490)) - Improve type annotations for `ObservableDeferred`. ([\matrix-org#10491](matrix-org#10491)) - Extend release script to also tag and create GitHub releases. ([\matrix-org#10496](matrix-org#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\matrix-org#10500](matrix-org#10500))

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\#10449](matrix-org/synapse#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\#10449](matrix-org/synapse#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\#10543](matrix-org/synapse#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\#10517](matrix-org/synapse#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\#10531](matrix-org/synapse#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\#10516](matrix-org/synapse#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\#9918](matrix-org/synapse#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\#10245](matrix-org/synapse#10245), [\#10432](matrix-org/synapse#10432), [\#10463](matrix-org/synapse#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\#10254](matrix-org/synapse#10254), [\#10447](matrix-org/synapse#10447), [\#10489](matrix-org/synapse#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\#10283](matrix-org/synapse#10283)) - Add a buffered logging handler which periodically flushes itself. ([\#10407](matrix-org/synapse#10407), [\#10515](matrix-org/synapse#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\#10411](matrix-org/synapse#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\#10413](matrix-org/synapse#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\#10426](matrix-org/synapse#10426)) - Allow setting transaction limit for database connections. ([\#10440](matrix-org/synapse#10440), [\#10511](matrix-org/synapse#10511)) - Add `creation_ts` to "list users" admin API. ([\#10448](matrix-org/synapse#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\#10410](matrix-org/synapse#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\#10439](matrix-org/synapse#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\#10455](matrix-org/synapse#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\#10499](matrix-org/synapse#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\#10445](matrix-org/synapse#10445)) - Consolidate development documentation to `docs/development/`. ([\#10453](matrix-org/synapse#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\#10464](matrix-org/synapse#10464)) - Document how to use Complement while developing a new Synapse feature. ([\#10483](matrix-org/synapse#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\#10390](matrix-org/synapse#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\#10408](matrix-org/synapse#10408)) - Remove shebang line from module files. ([\#10415](matrix-org/synapse#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\#10429](matrix-org/synapse#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\#10431](matrix-org/synapse#10431)) - Improve servlet type hints. ([\#10437](matrix-org/synapse#10437), [\#10438](matrix-org/synapse#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\#10442](matrix-org/synapse#10442)) - Update the `tests-done` Github Actions status. ([\#10444](matrix-org/synapse#10444), [\#10512](matrix-org/synapse#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\#10446](matrix-org/synapse#10446), [\#10450](matrix-org/synapse#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\#10451](matrix-org/synapse#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\#10468](matrix-org/synapse#10468)) - Additional type hints in the state handler. ([\#10482](matrix-org/synapse#10482)) - Update syntax used to run complement tests. ([\#10488](matrix-org/synapse#10488)) - Fix up type annotations to work with Twisted 21.7. ([\#10490](matrix-org/synapse#10490)) - Improve type annotations for `ObservableDeferred`. ([\#10491](matrix-org/synapse#10491)) - Extend release script to also tag and create GitHub releases. ([\#10496](matrix-org/synapse#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\#10500](matrix-org/synapse#10500))

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\matrix-org#10449](matrix-org#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\matrix-org#10449](matrix-org#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\matrix-org#10543](matrix-org#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\matrix-org#10517](matrix-org#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\matrix-org#10531](matrix-org#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\matrix-org#10516](matrix-org#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\matrix-org#9918](matrix-org#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#10245](matrix-org#10245), [\matrix-org#10432](matrix-org#10432), [\matrix-org#10463](matrix-org#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\matrix-org#10254](matrix-org#10254), [\matrix-org#10447](matrix-org#10447), [\matrix-org#10489](matrix-org#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\matrix-org#10283](matrix-org#10283)) - Add a buffered logging handler which periodically flushes itself. ([\matrix-org#10407](matrix-org#10407), [\matrix-org#10515](matrix-org#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\matrix-org#10411](matrix-org#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\matrix-org#10413](matrix-org#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\matrix-org#10426](matrix-org#10426)) - Allow setting transaction limit for database connections. ([\matrix-org#10440](matrix-org#10440), [\matrix-org#10511](matrix-org#10511)) - Add `creation_ts` to "list users" admin API. ([\matrix-org#10448](matrix-org#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\matrix-org#10410](matrix-org#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\matrix-org#10439](matrix-org#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\matrix-org#10455](matrix-org#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\matrix-org#10499](matrix-org#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\matrix-org#10445](matrix-org#10445)) - Consolidate development documentation to `docs/development/`. ([\matrix-org#10453](matrix-org#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\matrix-org#10464](matrix-org#10464)) - Document how to use Complement while developing a new Synapse feature. ([\matrix-org#10483](matrix-org#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\matrix-org#10390](matrix-org#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\matrix-org#10408](matrix-org#10408)) - Remove shebang line from module files. ([\matrix-org#10415](matrix-org#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\matrix-org#10429](matrix-org#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\matrix-org#10431](matrix-org#10431)) - Improve servlet type hints. ([\matrix-org#10437](matrix-org#10437), [\matrix-org#10438](matrix-org#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\matrix-org#10442](matrix-org#10442)) - Update the `tests-done` Github Actions status. ([\matrix-org#10444](matrix-org#10444), [\matrix-org#10512](matrix-org#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\matrix-org#10446](matrix-org#10446), [\matrix-org#10450](matrix-org#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\matrix-org#10451](matrix-org#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\matrix-org#10468](matrix-org#10468)) - Additional type hints in the state handler. ([\matrix-org#10482](matrix-org#10482)) - Update syntax used to run complement tests. ([\matrix-org#10488](matrix-org#10488)) - Fix up type annotations to work with Twisted 21.7. ([\matrix-org#10490](matrix-org#10490)) - Improve type annotations for `ObservableDeferred`. ([\matrix-org#10491](matrix-org#10491)) - Extend release script to also tag and create GitHub releases. ([\matrix-org#10496](matrix-org#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\matrix-org#10500](matrix-org#10500))

Bugsbane · 2022-06-09T03:23:08Z

So, does this merge support:

hiding read receipts for anyone in a specific room
hiding the display of read receipts from other users in the room, or
hiding your read receipts from being sent to others in the same room?

I'm running 1.59.7 (obviously after this merge was accepted) and I still don't see any way of avoiding having read receipts hidden in clients using rooms on my Synapse server.

SimonBrandner · 2022-06-10T15:44:01Z

So, does this merge support:

hiding read receipts for anyone in a specific room

hiding the display of read receipts from other users in the room, or

hiding your read receipts from being sent to others in the same room?

I'm running 1.59.7 (obviously after this merge was accepted) and I still don't see any way of avoiding having read receipts hidden in clients using rooms on my Synapse server.

This MSC adds support for sending private (previously hidden) read receipts to the server which won't get sent over to other clients, so it will look as if you did not read the message of the other users. From the end-user perspective, this essentially allows you to disable read receipts.

There are a few clients that support this such as Element Web/Desktop where this feature is hidden behind a labs option as it is still considered unstable (the MSC isn't merged yet)

tio-trom · 2022-07-27T04:52:27Z

this feature is hidden behind a labs option as it is still considered unstable (the MSC isn't merged yet)

I cannot find this in the labs section how can I enable it? I'd like to test it. Thanks! :)

SimonBrandner · 2022-07-27T18:06:59Z

this feature is hidden behind a labs option as it is still considered unstable (the MSC isn't merged yet)

I cannot find this in the labs section how can I enable it? I'd like to test it. Thanks! :)

I would recommend visiting https://matrix.to/#/#synapse:matrix.org :)

Add MSC2285

31d023a

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner mentioned this pull request Jul 16, 2021

Support for MSC2285 (hidden read receipts) matrix-org/matrix-react-sdk#6390

Merged

SimonBrandner force-pushed the feature/hidden-rrs branch 2 times, most recently from 5476f5e to 70eaa9e Compare July 16, 2021 10:13

SimonBrandner added 3 commits July 16, 2021 12:16

Implement MSC2285

2b28a13

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Test that hidden read receipts don't break unread counts

c7ff003

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Test that hidden read receipts are hidden

329ca23

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner force-pushed the feature/hidden-rrs branch 3 times, most recently from 9cac95a to 26234ca Compare July 16, 2021 10:21

SimonBrandner added 2 commits July 16, 2021 13:48

Test filtering of hidden events

5ba7be7

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Changelog

d11783c

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner force-pushed the feature/hidden-rrs branch 3 times, most recently from 1b92d84 to 3f47baf Compare July 19, 2021 09:27

SimonBrandner commented Jul 19, 2021

View reviewed changes

synapse/handlers/receipts.py Outdated Show resolved Hide resolved

Make filter_out_hidden static

c352751

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner force-pushed the feature/hidden-rrs branch from 3f47baf to 2cf11cd Compare July 19, 2021 09:31

SimonBrandner added 2 commits July 19, 2021 11:36

Handling of hidden read receipts for initial sync

1dcccd3

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Correctly handle hidden=True

59763c4

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner force-pushed the feature/hidden-rrs branch from 2cf11cd to 59763c4 Compare July 19, 2021 09:36

SimonBrandner marked this pull request as ready for review July 19, 2021 10:06

richvdh requested a review from a team July 22, 2021 09:13

babolivier self-assigned this Jul 22, 2021

babolivier suggested changes Jul 26, 2021

View reviewed changes

SimonBrandner added 5 commits July 26, 2021 15:49

_filters_correctly -> _test_filters_hidden

39f830c

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Add an MSC2285_HIDDEN const

b8ece44

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Use correct param name

b90949b

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Use 400 for consistency

93c87aa

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Add a comment about not using prefixes

77cd0d8

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner added 3 commits July 26, 2021 17:16

Hide MSC2285 behind a feature flag

d0d4dc6

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Delint

7743ab8

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Merge remote-tracking branch 'upstream/develop' into feature/hidden-rrs

8fd2929

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner requested a review from babolivier July 26, 2021 15:21

babolivier suggested changes Jul 27, 2021

View reviewed changes

tests/handlers/test_receipts.py Outdated Show resolved Hide resolved

synapse/handlers/receipts.py Outdated Show resolved Hide resolved

SimonBrandner and others added 2 commits July 27, 2021 18:32

Move comment

49dfd1d

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Make if statement more readable

944ee17

Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>

SimonBrandner requested a review from babolivier July 27, 2021 16:34

babolivier suggested changes Jul 27, 2021

View reviewed changes

tests/handlers/test_receipts.py Outdated Show resolved Hide resolved

SimonBrandner added 2 commits July 27, 2021 18:41

Move comment to an even better place

a02cf57

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Merge branch 'feature/hidden-rrs' of https://github.com/SimonBrandner…

ee87ab5

…/synapse into feature/hidden-rrs

babolivier approved these changes Jul 27, 2021

View reviewed changes

babolivier reviewed Jul 27, 2021

View reviewed changes

changelog.d/10413.feature Outdated Show resolved Hide resolved

Update changelog.d/10413.feature

f6ba3ac

babolivier merged commit c3b0377 into matrix-org:develop Jul 28, 2021

SimonBrandner deleted the feature/hidden-rrs branch July 28, 2021 10:57

babolivier mentioned this pull request Jul 28, 2021

MSC2285: Private read receipts matrix-org/matrix-spec-proposals#2285

Merged

sumnerevans mentioned this pull request Aug 3, 2021

[RFC 0094] Use Matrix for Official Chat NixOS/rfcs#94

Merged

babolivier mentioned this pull request Aug 4, 2021

Don't fail on empty bodies when sending out read receipts #10531

Merged

babolivier added a commit that referenced this pull request Aug 4, 2021

Don't fail on empty bodies when sending out read receipts (#10531)

e8a3e81

Fixes a bug introduced in rc1 that would cause Synapse to 400 on read receipts requests with empty bodies. Broken in #10413

reivilibre mentioned this pull request Aug 4, 2021

Spec compliance: require a request body on POST /rooms/{roomId}/receipt/{receiptType}/{eventId} #10534

Closed

4 tasks

anoadragon453 mentioned this pull request Aug 18, 2021

Add configuration for dropping read receipts #10177

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for MSC2285 (hidden read receipts) #10413

Support for MSC2285 (hidden read receipts) #10413

SimonBrandner commented Jul 16, 2021 •

edited

Loading

babolivier left a comment

SimonBrandner commented Jul 26, 2021

babolivier left a comment

babolivier left a comment

babolivier left a comment

Bugsbane commented Jun 9, 2022 •

edited

Loading

SimonBrandner commented Jun 10, 2022

tio-trom commented Jul 27, 2022

SimonBrandner commented Jul 27, 2022

Support for MSC2285 (hidden read receipts) #10413

Support for MSC2285 (hidden read receipts) #10413

Conversation

SimonBrandner commented Jul 16, 2021 • edited Loading

babolivier left a comment

Choose a reason for hiding this comment

SimonBrandner commented Jul 26, 2021

babolivier left a comment

Choose a reason for hiding this comment

babolivier left a comment

Choose a reason for hiding this comment

babolivier left a comment

Choose a reason for hiding this comment

Bugsbane commented Jun 9, 2022 • edited Loading

SimonBrandner commented Jun 10, 2022

tio-trom commented Jul 27, 2022

SimonBrandner commented Jul 27, 2022

SimonBrandner commented Jul 16, 2021 •

edited

Loading

Bugsbane commented Jun 9, 2022 •

edited

Loading