Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update contributing.md to warn against rebasing an open PR. #10563

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Update contributing.md to warn against rebasing an open PR. #10563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4eb74c2
update contributing to warn against rebasing an open PR
H-Shay Aug 9, 2021
5b93071
add changelog
H-Shay Aug 9, 2021
3bc7571
move changelog to appropriate directory
H-Shay Aug 9, 2021
a054cd7
remove file
H-Shay Aug 9, 2021
a377a63
Rename 10562.misc to 10563.misc
richvdh Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ To prepare a Pull Request, please:
4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request);
5. add a [changelog entry](#changelog) and push it to your Pull Request;
6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`.
7. if you need to update your PR, please avoid rebasing and just add new commits to your branch.


## Changelog
Expand Down
1 change: 1 addition & 0 deletions changelog.d/10563.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update contributing.md to warn against rebasing an open PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename this to a .doc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given it's developer rather than admin doc, I don't think it matters too much 🤷‍♂️