This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
start
andend
keys have been removed from the response to/publicRooms
, and replaced bynext_batch
andprev_batch
(whose existence depends on if there is a next or prev batch)./publicRooms
acceptlimit
andsince
parameters.{next,prev}_batch
tokens tosince=
. There is nodirection
parameter.since
token.new_rooms
is returned in the response when a since token is specified and is a boolean indicating if there are new rooms. Unpublished rooms do get removed, however.limit
param is advisory, in particular synapse will return fewer rooms if they have been unpublished.The response now looks something like:
Question: If we don't specify a limit, should we return the full list (current behaviour) or should we cap it?