Convert delete room admin API to async endpoint #11223

dklimpel · 2021-10-31T21:20:50Z

Fixes: #10797, #6934

Related to:

Shuting down a room with 4k+ users takes more than 2h #7651
Room deletion (shutdown) fail in a constant loop due to non-serializable access caused by PostgreSQL isolation levels #10294
Host dead after caches seem to break possibly due to multiple room delete commands in short period of time #10792

I have created two new endpoints:

DELETE /_synapse/admin/v2/rooms/<room_id>
GET /_synapse/admin/v2/rooms/<room_id>/delete_status

changes

moved functionality of RoomShutdownHandler into PaginationHandler
merged shutdown and purge room into one function/process
did not touched old functions, it should be removed after the new api is stable for a few month
added seperate unit tests
added result information to PurgeStatus

Questions

~~Is there a chance to define the new endpoint not as final to improve it in near feature if there are issues?~~
I do not know why the purge history endpoint creates a new <purge_id>. I have used the room_id instead. IMO this is easier for admins, because they do not have to memory a new id to get the status of process.
~~test test_delete_same_room_twice is flaky, do you have a hint to improve it? Otherwise I have to remove it.~~

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
Pull request includes a sign off
Code style is correct (run the linters)

Signed-off-by: Dirk Klimpel dirk@klimpel.org

richvdh · 2021-11-01T15:21:34Z

Is there a chance to define the new endpoint not as final to improve it in near feature if there are issues?

I think the best way to do this is by flagging it as experimental and "subject to change" in the documentation.

found there: matrix-org#7964 (comment)

richvdh · 2021-11-01T16:21:15Z

I do not know why the purge history endpoint creates a new <purge_id>. I have used the room_id instead. IMO this is easier for admins, because they do not have to memory a new id to get the status of process.

I think one reason for this is because there can be multiple requests for the same room. For example, the first request might not go back far enough, or might have failed. By giving each request its own id, you can make sure that you're getting the results for the right request.

I hear your point that it's harder for external tools to use, though. Happy for it to just use room id for now.

dklimpel · 2021-11-01T17:08:48Z

Ok. That is a good point.
Maybe it makes sense to create an id for the uniqueness and to query the last status of the room with the room_id?

dklimpel · 2021-11-01T17:23:45Z

Probably I have to adjust this PR after merging

Allow admins to proactively block rooms #11228

docs/admin_api/rooms.md

synapse/handlers/pagination.py

tests/rest/admin/test_room.py

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

and use `run_as_background_process`

Conflicts: tests/rest/admin/test_room.py

tests/rest/admin/test_room.py

dklimpel · 2021-11-04T17:07:02Z

Do you have any better idea for the name of the returned object then delete_status?

{
    "delete_status": [
        {
            "purge_id": "purgeid1",
            "status": "failed",
            "result": {
                "kicked_users": [],
                "failed_to_kick_users": [],
                "local_aliases": [],
                "new_room_id": null
            }
        }
    ]
}

Conflicts: docs/admin_api/rooms.md

richvdh · 2021-11-11T16:53:14Z

docs/admin_api/rooms.md

-to this homeserver. In this case, the room will be blocked, and no further action
-will be taken. If `block` is `false`, attempting to delete an unknown room is
-invalid and will be rejected as a bad request.
+This option can in [Version 1](#version-1-old-version) also be used to pre-emptively


wait, what? why are we removing this ability? It's important to be able to pre-emptively block rooms.

That ist not removed. The ability in Version 1 is created in #11228 and there is also an issue #11283.
IMO a simple block of a room with a bg task is not a very good usage. And it is implemented with raise and catching exceptions. I think v1 of this API should be removed after publishing the block API.

hrm. Ok, let's leave it for now.

richvdh · 2021-11-11T17:14:32Z

fixes: #6934

docs/admin_api/purge_history_api.md

docs/admin_api/rooms.md

synapse/handlers/pagination.py

synapse/handlers/room.py

synapse/handlers/pagination.py

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

richvdh

🎉 thanks @dklimpel , let's get this thing shipped!

dklimpel · 2021-11-12T13:28:48Z

🎉 thanks @dklimpel , let's get this thing shipped!

Thank you for your patience. The PR is unusually large and complex.

@tulir

Synapse 1.48.0 (2021-11-30) =========================== This release removes support for the long-deprecated `trust_identity_server_for_password_resets` configuration flag. This release also fixes some performance issues with some background database updates introduced in Synapse 1.47.0. No significant changes since 1.48.0rc1. Synapse 1.48.0rc1 (2021-11-25) ============================== Features -------- - Experimental support for the thread relation defined in [MSC3440](matrix-org/matrix-spec-proposals#3440). ([\#11161](matrix-org/synapse#11161)) - Support filtering by relation senders & types per [MSC3440](matrix-org/matrix-spec-proposals#3440). ([\#11236](matrix-org/synapse#11236)) - Add support for the `/_matrix/client/v3` and `/_matrix/media/v3` APIs from Matrix v1.1. ([\#11318](matrix-org/synapse#11318), [\#11371](matrix-org/synapse#11371)) - Support the stable version of [MSC2778](matrix-org/matrix-spec-proposals#2778): the `m.login.application_service` login type. Contributed by @tulir. ([\#11335](matrix-org/synapse#11335)) - Add a new version of delete room admin API `DELETE /_synapse/admin/v2/rooms/<room_id>` to run it in the background. Contributed by @dklimpel. ([\#11223](matrix-org/synapse#11223)) - Allow the admin [Delete Room API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#delete-room-api) to block a room without the need to join it. ([\#11228](matrix-org/synapse#11228)) - Add an admin API to un-shadow-ban a user. ([\#11347](matrix-org/synapse#11347)) - Add an admin API to run background database schema updates. ([\#11352](matrix-org/synapse#11352)) - Add an admin API for blocking a room. ([\#11324](matrix-org/synapse#11324)) - Update the JWT login type to support custom a `sub` claim. ([\#11361](matrix-org/synapse#11361)) - Store and allow querying of arbitrary event relations. ([\#11391](matrix-org/synapse#11391)) Bugfixes -------- - Fix a long-standing bug wherein display names or avatar URLs containing null bytes cause an internal server error when stored in the DB. ([\#11230](matrix-org/synapse#11230)) - Prevent [MSC2716](matrix-org/matrix-spec-proposals#2716) historical state events from being pushed to an application service via `/transactions`. ([\#11265](matrix-org/synapse#11265)) - Fix a long-standing bug where uploading extremely thin images (e.g. 1000x1) would fail. Contributed by @Neeeflix. ([\#11288](matrix-org/synapse#11288)) - Fix a bug, introduced in Synapse 1.46.0, which caused the `check_3pid_auth` and `on_logged_out` callbacks in legacy password authentication provider modules to not be registered. Modules using the generic module interface were not affected. ([\#11340](matrix-org/synapse#11340)) - Fix a bug introduced in 1.41.0 where space hierarchy responses would be incorrectly reused if multiple users were to make the same request at the same time. ([\#11355](matrix-org/synapse#11355)) - Fix a bug introduced in 1.45.0 where the `read_templates` method of the module API would error. ([\#11377](matrix-org/synapse#11377)) - Fix an issue introduced in 1.47.0 which prevented servers re-joining rooms they had previously left, if their signing keys were replaced. ([\#11379](matrix-org/synapse#11379)) - Fix a bug introduced in 1.13.0 where creating and publishing a room could cause errors if `room_list_publication_rules` is configured. ([\#11392](matrix-org/synapse#11392)) - Improve performance of various background database updates. ([\#11421](matrix-org/synapse#11421), [\#11422](matrix-org/synapse#11422)) Improved Documentation ---------------------- - Suggest users of the Debian packages add configuration to `/etc/matrix-synapse/conf.d/` to prevent, upon upgrade, being asked to choose between their configuration and the maintainer's. ([\#11281](matrix-org/synapse#11281)) - Fix typos in the documentation for the `username_available` admin API. Contributed by Stanislav Motylkov. ([\#11286](matrix-org/synapse#11286)) - Add Single Sign-On, SAML and CAS pages to the documentation. ([\#11298](matrix-org/synapse#11298)) - Change the word 'Home server' as one word 'homeserver' in documentation. ([\#11320](matrix-org/synapse#11320)) - Fix missing quotes for wildcard domains in `federation_certificate_verification_whitelist`. ([\#11381](matrix-org/synapse#11381)) Deprecations and Removals ------------------------- - Remove deprecated `trust_identity_server_for_password_resets` configuration flag. ([\#11333](matrix-org/synapse#11333), [\#11395](matrix-org/synapse#11395)) Internal Changes ---------------- - Add type annotations to `synapse.metrics`. ([\#10847](matrix-org/synapse#10847)) - Split out federated PDU retrieval function into a non-cached version. ([\#11242](matrix-org/synapse#11242)) - Clean up code relating to to-device messages and sending ephemeral events to application services. ([\#11247](matrix-org/synapse#11247)) - Fix a small typo in the error response when a relation type other than 'm.annotation' is passed to `GET /rooms/{room_id}/aggregations/{event_id}`. ([\#11278](matrix-org/synapse#11278)) - Drop unused database tables `room_stats_historical` and `user_stats_historical`. ([\#11280](matrix-org/synapse#11280)) - Require all files in synapse/ and tests/ to pass mypy unless specifically excluded. ([\#11282](matrix-org/synapse#11282), [\#11285](matrix-org/synapse#11285), [\#11359](matrix-org/synapse#11359)) - Add missing type hints to `synapse.app`. ([\#11287](matrix-org/synapse#11287)) - Remove unused parameters on `FederationEventHandler._check_event_auth`. ([\#11292](matrix-org/synapse#11292)) - Add type hints to `synapse._scripts`. ([\#11297](matrix-org/synapse#11297)) - Fix an issue which prevented the `remove_deleted_devices_from_device_inbox` background database schema update from running when updating from a recent Synapse version. ([\#11303](matrix-org/synapse#11303)) - Add type hints to storage classes. ([\#11307](matrix-org/synapse#11307), [\#11310](matrix-org/synapse#11310), [\#11311](matrix-org/synapse#11311), [\#11312](matrix-org/synapse#11312), [\#11313](matrix-org/synapse#11313), [\#11314](matrix-org/synapse#11314), [\#11316](matrix-org/synapse#11316), [\#11322](matrix-org/synapse#11322), [\#11332](matrix-org/synapse#11332), [\#11339](matrix-org/synapse#11339), [\#11342](matrix-org/synapse#11342)) - Add type hints to `synapse.util`. ([\#11321](matrix-org/synapse#11321), [\#11328](matrix-org/synapse#11328)) - Improve type annotations in Synapse's test suite. ([\#11323](matrix-org/synapse#11323), [\#11330](matrix-org/synapse#11330)) - Test that room alias deletion works as intended. ([\#11327](matrix-org/synapse#11327)) - Add type annotations for some methods and properties in the module API. ([\#11341](matrix-org/synapse#11341)) - Fix running `scripts-dev/complement.sh`, which was broken in v1.47.0rc1. ([\#11368](matrix-org/synapse#11368)) - Rename internal functions for token generation to better reflect what they do. ([\#11369](matrix-org/synapse#11369), [\#11370](matrix-org/synapse#11370)) - Add type hints to configuration classes. ([\#11377](matrix-org/synapse#11377)) - Publish a `develop` image to Docker Hub. ([\#11380](matrix-org/synapse#11380)) - Keep fallback key marked as used if it's re-uploaded. ([\#11382](matrix-org/synapse#11382)) - Use `auto_attribs` on the `attrs` class `RefreshTokenLookupResult`. ([\#11386](matrix-org/synapse#11386)) - Rename unstable `access_token_lifetime` configuration option to `refreshable_access_token_lifetime` to make it clear it only concerns refreshable access tokens. ([\#11388](matrix-org/synapse#11388)) - Do not run the broken MSC2716 tests when running `scripts-dev/complement.sh`. ([\#11389](matrix-org/synapse#11389)) - Remove dead code from supporting ACME. ([\#11393](matrix-org/synapse#11393)) - Refactor including the bundled relations when serializing an event. ([\#11408](matrix-org/synapse#11408))

@tulir

Synapse 1.48.0 (2021-11-30) =========================== This release removes support for the long-deprecated `trust_identity_server_for_password_resets` configuration flag. This release also fixes some performance issues with some background database updates introduced in Synapse 1.47.0. Features -------- - Experimental support for the thread relation defined in [MSC3440](matrix-org/matrix-spec-proposals#3440). ([\#11161](matrix-org/synapse#11161)) - Support filtering by relation senders & types per [MSC3440](matrix-org/matrix-spec-proposals#3440). ([\#11236](matrix-org/synapse#11236)) - Add support for the `/_matrix/client/v3` and `/_matrix/media/v3` APIs from Matrix v1.1. ([\#11318](matrix-org/synapse#11318), [\#11371](matrix-org/synapse#11371)) - Support the stable version of [MSC2778](matrix-org/matrix-spec-proposals#2778): the `m.login.application_service` login type. Contributed by @tulir. ([\#11335](matrix-org/synapse#11335)) - Add a new version of delete room admin API `DELETE /_synapse/admin/v2/rooms/<room_id>` to run it in the background. Contributed by @dklimpel. ([\#11223](matrix-org/synapse#11223)) - Allow the admin [Delete Room API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#delete-room-api) to block a room without the need to join it. ([\#11228](matrix-org/synapse#11228)) - Add an admin API to un-shadow-ban a user. ([\#11347](matrix-org/synapse#11347)) - Add an admin API to run background database schema updates. ([\#11352](matrix-org/synapse#11352)) - Add an admin API for blocking a room. ([\#11324](matrix-org/synapse#11324)) - Update the JWT login type to support custom a `sub` claim. ([\#11361](matrix-org/synapse#11361)) - Store and allow querying of arbitrary event relations. ([\#11391](matrix-org/synapse#11391)) Deprecations and Removals ------------------------- - Remove deprecated `trust_identity_server_for_password_resets` configuration flag. ([\#11333](matrix-org/synapse#11333), [\#11395](matrix-org/synapse#11395))

@tulir

Synapse 1.48.0 (2021-11-30) =========================== This release removes support for the long-deprecated `trust_identity_server_for_password_resets` configuration flag. This release also fixes some performance issues with some background database updates introduced in Synapse 1.47.0. No significant changes since 1.48.0rc1. Synapse 1.48.0rc1 (2021-11-25) ============================== Features -------- - Experimental support for the thread relation defined in [MSC3440](matrix-org/matrix-spec-proposals#3440). ([\matrix-org#11161](matrix-org#11161)) - Support filtering by relation senders & types per [MSC3440](matrix-org/matrix-spec-proposals#3440). ([\matrix-org#11236](matrix-org#11236)) - Add support for the `/_matrix/client/v3` and `/_matrix/media/v3` APIs from Matrix v1.1. ([\matrix-org#11318](matrix-org#11318), [\matrix-org#11371](matrix-org#11371)) - Support the stable version of [MSC2778](matrix-org/matrix-spec-proposals#2778): the `m.login.application_service` login type. Contributed by @tulir. ([\matrix-org#11335](matrix-org#11335)) - Add a new version of delete room admin API `DELETE /_synapse/admin/v2/rooms/<room_id>` to run it in the background. Contributed by @dklimpel. ([\matrix-org#11223](matrix-org#11223)) - Allow the admin [Delete Room API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#delete-room-api) to block a room without the need to join it. ([\matrix-org#11228](matrix-org#11228)) - Add an admin API to un-shadow-ban a user. ([\matrix-org#11347](matrix-org#11347)) - Add an admin API to run background database schema updates. ([\matrix-org#11352](matrix-org#11352)) - Add an admin API for blocking a room. ([\matrix-org#11324](matrix-org#11324)) - Update the JWT login type to support custom a `sub` claim. ([\matrix-org#11361](matrix-org#11361)) - Store and allow querying of arbitrary event relations. ([\matrix-org#11391](matrix-org#11391)) Bugfixes -------- - Fix a long-standing bug wherein display names or avatar URLs containing null bytes cause an internal server error when stored in the DB. ([\matrix-org#11230](matrix-org#11230)) - Prevent [MSC2716](matrix-org/matrix-spec-proposals#2716) historical state events from being pushed to an application service via `/transactions`. ([\matrix-org#11265](matrix-org#11265)) - Fix a long-standing bug where uploading extremely thin images (e.g. 1000x1) would fail. Contributed by @Neeeflix. ([\matrix-org#11288](matrix-org#11288)) - Fix a bug, introduced in Synapse 1.46.0, which caused the `check_3pid_auth` and `on_logged_out` callbacks in legacy password authentication provider modules to not be registered. Modules using the generic module interface were not affected. ([\matrix-org#11340](matrix-org#11340)) - Fix a bug introduced in 1.41.0 where space hierarchy responses would be incorrectly reused if multiple users were to make the same request at the same time. ([\matrix-org#11355](matrix-org#11355)) - Fix a bug introduced in 1.45.0 where the `read_templates` method of the module API would error. ([\matrix-org#11377](matrix-org#11377)) - Fix an issue introduced in 1.47.0 which prevented servers re-joining rooms they had previously left, if their signing keys were replaced. ([\matrix-org#11379](matrix-org#11379)) - Fix a bug introduced in 1.13.0 where creating and publishing a room could cause errors if `room_list_publication_rules` is configured. ([\matrix-org#11392](matrix-org#11392)) - Improve performance of various background database updates. ([\matrix-org#11421](matrix-org#11421), [\matrix-org#11422](matrix-org#11422)) Improved Documentation ---------------------- - Suggest users of the Debian packages add configuration to `/etc/matrix-synapse/conf.d/` to prevent, upon upgrade, being asked to choose between their configuration and the maintainer's. ([\matrix-org#11281](matrix-org#11281)) - Fix typos in the documentation for the `username_available` admin API. Contributed by Stanislav Motylkov. ([\matrix-org#11286](matrix-org#11286)) - Add Single Sign-On, SAML and CAS pages to the documentation. ([\matrix-org#11298](matrix-org#11298)) - Change the word 'Home server' as one word 'homeserver' in documentation. ([\matrix-org#11320](matrix-org#11320)) - Fix missing quotes for wildcard domains in `federation_certificate_verification_whitelist`. ([\matrix-org#11381](matrix-org#11381)) Deprecations and Removals ------------------------- - Remove deprecated `trust_identity_server_for_password_resets` configuration flag. ([\matrix-org#11333](matrix-org#11333), [\matrix-org#11395](matrix-org#11395)) Internal Changes ---------------- - Add type annotations to `synapse.metrics`. ([\matrix-org#10847](matrix-org#10847)) - Split out federated PDU retrieval function into a non-cached version. ([\matrix-org#11242](matrix-org#11242)) - Clean up code relating to to-device messages and sending ephemeral events to application services. ([\matrix-org#11247](matrix-org#11247)) - Fix a small typo in the error response when a relation type other than 'm.annotation' is passed to `GET /rooms/{room_id}/aggregations/{event_id}`. ([\matrix-org#11278](matrix-org#11278)) - Drop unused database tables `room_stats_historical` and `user_stats_historical`. ([\matrix-org#11280](matrix-org#11280)) - Require all files in synapse/ and tests/ to pass mypy unless specifically excluded. ([\matrix-org#11282](matrix-org#11282), [\matrix-org#11285](matrix-org#11285), [\matrix-org#11359](matrix-org#11359)) - Add missing type hints to `synapse.app`. ([\matrix-org#11287](matrix-org#11287)) - Remove unused parameters on `FederationEventHandler._check_event_auth`. ([\matrix-org#11292](matrix-org#11292)) - Add type hints to `synapse._scripts`. ([\matrix-org#11297](matrix-org#11297)) - Fix an issue which prevented the `remove_deleted_devices_from_device_inbox` background database schema update from running when updating from a recent Synapse version. ([\matrix-org#11303](matrix-org#11303)) - Add type hints to storage classes. ([\matrix-org#11307](matrix-org#11307), [\matrix-org#11310](matrix-org#11310), [\matrix-org#11311](matrix-org#11311), [\matrix-org#11312](matrix-org#11312), [\matrix-org#11313](matrix-org#11313), [\matrix-org#11314](matrix-org#11314), [\matrix-org#11316](matrix-org#11316), [\matrix-org#11322](matrix-org#11322), [\matrix-org#11332](matrix-org#11332), [\matrix-org#11339](matrix-org#11339), [\matrix-org#11342](matrix-org#11342)) - Add type hints to `synapse.util`. ([\matrix-org#11321](matrix-org#11321), [\matrix-org#11328](matrix-org#11328)) - Improve type annotations in Synapse's test suite. ([\matrix-org#11323](matrix-org#11323), [\matrix-org#11330](matrix-org#11330)) - Test that room alias deletion works as intended. ([\matrix-org#11327](matrix-org#11327)) - Add type annotations for some methods and properties in the module API. ([\matrix-org#11341](matrix-org#11341)) - Fix running `scripts-dev/complement.sh`, which was broken in v1.47.0rc1. ([\matrix-org#11368](matrix-org#11368)) - Rename internal functions for token generation to better reflect what they do. ([\matrix-org#11369](matrix-org#11369), [\matrix-org#11370](matrix-org#11370)) - Add type hints to configuration classes. ([\matrix-org#11377](matrix-org#11377)) - Publish a `develop` image to Docker Hub. ([\matrix-org#11380](matrix-org#11380)) - Keep fallback key marked as used if it's re-uploaded. ([\matrix-org#11382](matrix-org#11382)) - Use `auto_attribs` on the `attrs` class `RefreshTokenLookupResult`. ([\matrix-org#11386](matrix-org#11386)) - Rename unstable `access_token_lifetime` configuration option to `refreshable_access_token_lifetime` to make it clear it only concerns refreshable access tokens. ([\matrix-org#11388](matrix-org#11388)) - Do not run the broken MSC2716 tests when running `scripts-dev/complement.sh`. ([\matrix-org#11389](matrix-org#11389)) - Remove dead code from supporting ACME. ([\matrix-org#11393](matrix-org#11393)) - Refactor including the bundled relations when serializing an event. ([\matrix-org#11408](matrix-org#11408))

Convert delete room admin API to async endpoint

c35a367

dklimpel requested a review from a team as a code owner October 31, 2021 21:20

dklimpel added 2 commits October 31, 2021 22:24

newsfile

69bba24

disable flaky test

a9f9e3a

dklimpel force-pushed the delete_room_bg branch from 0a0608a to a9f9e3a Compare October 31, 2021 22:16

richvdh self-assigned this Nov 1, 2021

dklimpel mentioned this pull request Nov 1, 2021

Add an option to disable purge in delete room admin API #7964

Merged

4 tasks

dklimpel added 2 commits November 1, 2021 16:40

Merge branch 'develop' into delete_room_bg

9d381cf

Fix wrong unit test test_block_room_and_not_purge

6ddcc8e

found there: matrix-org#7964 (comment)

richvdh reviewed Nov 1, 2021

View reviewed changes

richvdh removed their assignment Nov 1, 2021

richvdh added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Nov 1, 2021

Apply suggestions from code review

cf8b612

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

dklimpel marked this pull request as draft November 2, 2021 06:48

dklimpel added 3 commits November 2, 2021 08:15

update docstrings and mark private fields with _

a37b09c

and use `run_as_background_process`

Merge remote-tracking branch 'synapse/develop' into delete_room_bg

5b24839

Reuse RoomShutdownHandler.shutdown_room

3f9a4f4

dklimpel force-pushed the delete_room_bg branch 2 times, most recently from 405b080 to 3f9a4f4 Compare November 3, 2021 09:27

dklimpel added 3 commits November 3, 2021 10:31

Merge remote-tracking branch 'synapse/develop' into delete_room_bg

a482170

Conflicts: tests/rest/admin/test_room.py

try flaky unit test

2f1f483

rework request of purge status

60ef11e

dklimpel commented Nov 4, 2021

View reviewed changes

tests/rest/admin/test_room.py Outdated Show resolved Hide resolved

dklimpel requested a review from richvdh November 4, 2021 17:08

dklimpel mentioned this pull request Nov 5, 2021

Allow admins to proactively block rooms #11228

Merged

richvdh self-requested a review November 9, 2021 11:29

dklimpel added 6 commits November 9, 2021 18:52

Merge remote-tracking branch 'synapse/develop' into delete_room_bg

fb2019d

Conflicts: docs/admin_api/rooms.md

fix merge

3b3cf2a

update test response code, introduced in matrix-org#11228

bd70ffd

Merge remote-tracking branch 'synapse/develop' into delete_room_bg

383d808

make compatible with matrix-org#11228

05dd106

rename status

11d9e87

dklimpel marked this pull request as ready for review November 9, 2021 20:49

reivilibre removed the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Nov 10, 2021

richvdh added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Nov 10, 2021

richvdh removed their request for review November 10, 2021 17:55

separate purge and delete

fea716f

dklimpel requested a review from richvdh November 10, 2021 22:27

richvdh reviewed Nov 11, 2021

View reviewed changes

richvdh linked an issue Nov 11, 2021 that may be closed by this pull request

Purge status failure should tell you why it failed #6934

Closed

richvdh reviewed Nov 11, 2021

View reviewed changes

synapse/handlers/pagination.py Outdated Show resolved Hide resolved

dklimpel and others added 2 commits November 11, 2021 18:54

Apply suggestions from code review

1e5c5a4

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

lint and small fixes

949e55f

dklimpel force-pushed the delete_room_bg branch from 6839f30 to 949e55f Compare November 11, 2021 19:15

richvdh approved these changes Nov 12, 2021

View reviewed changes

richvdh removed the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Nov 12, 2021

richvdh merged commit 8840a7b into matrix-org:develop Nov 12, 2021

dklimpel deleted the delete_room_bg branch November 12, 2021 13:29

richvdh mentioned this pull request May 19, 2022

Host dead after caches seem to break possibly due to multiple room delete commands in short period of time #10792

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert delete room admin API to async endpoint #11223

Convert delete room admin API to async endpoint #11223

dklimpel commented Oct 31, 2021 •

edited

Loading

richvdh commented Nov 1, 2021

richvdh commented Nov 1, 2021

dklimpel commented Nov 1, 2021

dklimpel commented Nov 1, 2021

dklimpel commented Nov 4, 2021 •

edited

Loading

richvdh Nov 11, 2021

dklimpel Nov 11, 2021

richvdh Nov 11, 2021

richvdh commented Nov 11, 2021 •

edited

Loading

richvdh left a comment

dklimpel commented Nov 12, 2021

Convert delete room admin API to async endpoint #11223

Convert delete room admin API to async endpoint #11223

Conversation

dklimpel commented Oct 31, 2021 • edited Loading

Pull Request Checklist

richvdh commented Nov 1, 2021

richvdh commented Nov 1, 2021

dklimpel commented Nov 1, 2021

dklimpel commented Nov 1, 2021

dklimpel commented Nov 4, 2021 • edited Loading

richvdh Nov 11, 2021

Choose a reason for hiding this comment

dklimpel Nov 11, 2021

Choose a reason for hiding this comment

richvdh Nov 11, 2021

Choose a reason for hiding this comment

richvdh commented Nov 11, 2021 • edited Loading

richvdh left a comment

Choose a reason for hiding this comment

dklimpel commented Nov 12, 2021

dklimpel commented Oct 31, 2021 •

edited

Loading

dklimpel commented Nov 4, 2021 •

edited

Loading

richvdh commented Nov 11, 2021 •

edited

Loading