Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update outdated links in PULL_REQUEST_TEMPLATE.md #11225

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Update outdated links in PULL_REQUEST_TEMPLATE.md #11225

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e9b60d
Update outdated links in `PULL_REQUEST_TEMPLATE.md`
dklimpel Nov 1, 2021
9f454f5
newsfile
dklimpel Nov 1, 2021
2b96929
Merge branch 'matrix-org:develop' into patch-1
dklimpel Nov 1, 2021
d1d3abb
Apply suggestions from code review
dklimpel Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
<!-- Please read CONTRIBUTING.md before submitting your pull request -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change this comment to refer to https://matrix-org.github.io/synapse/latest/development/contributing_guide.html)?

dklimpel marked this conversation as resolved.
Show resolved Hide resolved

* [ ] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog file](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#changelog). The entry should:
* [ ] Pull request includes a [changelog file](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
* [ ] Pull request includes a [sign off](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#sign-off)
* [ ] Code style is correct (run the [linters](https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.md#code-style))
* [ ] Pull request includes a [sign off](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off)
* [ ] [Code style](https://matrix-org.github.io/synapse/latest/code_style.html) is correct
(run the [linters](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
1 change: 1 addition & 0 deletions changelog.d/11225.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update outdated links in contribution comments (`PULL_REQUEST_TEMPLATE.md`).
dklimpel marked this conversation as resolved.
Show resolved Hide resolved