Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add jitsi config #12097

Closed
wants to merge 1 commit into from
Closed

Conversation

manju-rn
Copy link

@manju-rn manju-rn commented Feb 27, 2022

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@manju-rn manju-rn requested a review from a team as a code owner February 27, 2022 09:15
@manju-rn
Copy link
Author

This PR adds a json configuration to .well-known/matrix/client for jitsi configuration. This resolves the issue as raised in #8739.

@richvdh richvdh changed the title Added jitsi config Add jitsi config Feb 28, 2022
@squahtx
Copy link
Contributor

squahtx commented Mar 1, 2022

@manju-rn Thank you for contributing to Synapse! While this PR does fix the issue encountered by some users in #8739, we were hoping for a more generic solution along the lines of samiraguiar's suggestion (#8739 (comment)), ie. a config option holding a dict or specifying a json file that gets merged into the .well-known/matrix/client response. Do you think you could implement something like that?

@squahtx squahtx added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Mar 1, 2022
@manju-rn
Copy link
Author

manju-rn commented Mar 1, 2022

@manju-rn Thank you for contributing to Synapse! While this PR does fix the issue encountered by some users in #8739, we were hoping for a more generic solution along the lines of samiraguiar's suggestion (#8739 (comment)), ie. a config option holding a dict or specifying a json file that gets merged into the .well-known/matrix/client response. Do you think you could implement something like that?

I am not sure if you have checked the code. The PR does add a config entry in the homeserver.yaml, reads in config/server.py and appends to the JSON (in well-known/matrix/client) created in wellknown.py. Hence, I believe this is generic solution

@squahtx
Copy link
Contributor

squahtx commented Mar 1, 2022

#8739 is about all possible customizations and not just jitsi. We would like to allow server admins to configure "io.element.e2ee", for example.

@manju-rn
Copy link
Author

manju-rn commented Mar 2, 2022

#8739 is about all possible customizations and not just jitsi. We would like to allow server admins to configure "io.element.e2ee", for example.

okay. don't think I would go into that as of now. So this PR is rejected?

@squahtx
Copy link
Contributor

squahtx commented Mar 2, 2022

okay. don't think I would go into that as of now. So this PR is rejected?

That's unfortunate to hear. We're going to have to decline this PR for now.
If you ever feel up for it, a PR that handles arbitrary customizations would be very welcome.

@squahtx squahtx closed this Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants