Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Disallow untyped defs in synapse._scripts #12422

Merged
merged 13 commits into from
Apr 11, 2022
Merged

Disallow untyped defs in synapse._scripts #12422

merged 13 commits into from
Apr 11, 2022

Commits on Apr 8, 2022

  1. no untyped defs in move_remote_media_to_new_store

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    5e0be14 View commit details
    Browse the repository at this point in the history

  2. no untyped defs in hash_password

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    cb135af View commit details
    Browse the repository at this point in the history

  3. no untyped defs in export_signing_key

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e54c338 View commit details
    Browse the repository at this point in the history

  4. No untyped defs in update_synapse_database

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    f58db2d View commit details
    Browse the repository at this point in the history

  5. No untyped defs in generate_signing_key

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    8a6fdfc View commit details
    Browse the repository at this point in the history

  6. No untyped defs in generate_config

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d664e4f View commit details
    Browse the repository at this point in the history

  7. No untyped defs in generate_log_config

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    871809a View commit details
    Browse the repository at this point in the history

  8. No untyped defs in synctl

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    8fb1187 View commit details
    Browse the repository at this point in the history

  9. No untyped defs in register_new_matrix_user 

    This one might be contraversial. `request_registration` has three
dependency-injection arguments used for testing. I'm removing the
injection of the `requests` module and using `unitest.mock.patch` in the
test cases instead.

Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the
change:

```
synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any"
synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any"
```

And after:

```
synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType"
synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response"
```
    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d960589 View commit details
    Browse the repository at this point in the history

  10. Drive-by comment in synapse.storage.types

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    801be79 View commit details
    Browse the repository at this point in the history

  11. No untyped defs in synapse_port_db 

    This was by far the most painful. I'm happy to break this up into
smaller pieces for review if it's not managable as-is.
    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    82b0d52 View commit details
    Browse the repository at this point in the history

  12. Scripts is typed.

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    55fdb4d View commit details
    Browse the repository at this point in the history

  13. changelog

    David Robertson committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    728df44 View commit details
    Browse the repository at this point in the history