Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Respect the @cancellable flag for DirectServe{Html,Json}Resources #12698

Merged
merged 4 commits into from
May 11, 2022
Merged

Respect the @cancellable flag for DirectServe{Html,Json}Resources #12698

merged 4 commits into from
May 11, 2022

Commits on May 10, 2022

  1. Respect the @cancellable flag for DirectServe{Html,Json}Resources 

    `DirectServeHtmlResource` and `DirectServeJsonResource` both inherit
from `_AsyncResource`. These classes expect to be subclassed with
`_async_render_*` methods.

This commit has no effect on `JsonResource`, despite inheriting from
`_AsyncResource`. `JsonResource` has its own `_async_render` override
which will need to be updated separately.

Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    4964151 View commit details
    Browse the repository at this point in the history

  2. Test the @cancellable flag on DirectServe{Html,Json}Resource methods 

    Signed-off-by: Sean Quah <seanq@element.io>
    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8fd36ec View commit details
    Browse the repository at this point in the history

  3. Add newsfile

    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    86245bf View commit details
    Browse the repository at this point in the history

  4. Fix CI

    Sean Quah committed May 10, 2022
    Configuration menu
    Copy the full SHA
    adde6a3 View commit details
    Browse the repository at this point in the history