This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changelog entry is not very descriptive and doesn't explain why we made the change (what was broken before).
For reference, these changes are spawning from some discussion in #synapse-dev:matrix.org which discusses the
ModuleNotFoundError: No module named 'matrix_common'
errors popping up when Complement is running in CI.As far as I can tell, the dependency was missing in CI because of this reason mentioned in the room discussion:
As the issue description already mentions, the root cause might be because we didn't pin
poetry-core
before and it was pulling in a recent beta release which introduced the unexpected problem behavior. In any case, pinning topoetry-core==1.1.0a7
makes it work as expected to install all of the deps.This information should also be in the PR description. I'm not confident in my conclusion here to update it myself.