Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Drop unused columns from event_edges #13217

Closed
wants to merge 1 commit into from

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 7, 2022

event_edges.room_id and event_edges.is_state have been unused since Synapse 1.62.0rc1 (#12893), so we can now remove them.

Fixes #12892

@richvdh richvdh force-pushed the rav/drop_event_edges_cols branch from 16eeabd to 776591a Compare July 7, 2022 21:37
@richvdh richvdh force-pushed the rav/drop_event_edges_cols branch from 776591a to 4399fed Compare July 7, 2022 22:00
@richvdh
Copy link
Member Author

richvdh commented Jul 15, 2022

it turns out that is_state is still queried in a few places, and getting rid of those queries is somewhat non-trivial, since the bad rows are removed in a background update.

At some point, the solution may be to block startup until the bg updates complete; but we're not ready for that yet.

@richvdh richvdh closed this Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant event_edges.room_id and event_edges.is_state columns
1 participant