Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Return 403 when GETing /joined_members after leaving #13374

Merged
merged 29 commits into from
Aug 3, 2022
Merged

Return 403 when GETing /joined_members after leaving #13374

merged 29 commits into from
Aug 3, 2022

Conversation

andrewdoh
Copy link
Contributor

@andrewdoh andrewdoh commented Jul 24, 2022 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

andrewdoh and others added 22 commits May 3, 2022 19:25
@andrewdoh
remove constantly lib use and switch to enums.
3c10c80 
Signed-off-by: Andrew Do <andrewddo@gmail.com>
@andrewdoh
add changlog for pr 12624.
9a450fc
@andrewdoh
Fix capitalization of sentence and add credit.
317065a
@andrewdoh
resolve conflict with mypy.ini, pulled from upstream.
ed6b772
@andrewdoh
update function docstring description to new updated enum values.
2b1fe9a
@clokep
Update changelog.
7c9e5db
@andrewdoh
Merge remote-tracking branch 'upstream/develop' into develop
9dfe96a
@andrewdoh
Merge remote-tracking branch 'upstream/develop' into develop
10ef848
@andrewdoh
add room_type to list room and room details API response.
32759dc 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
refactor changelog file to expected number.
db7010b 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
add room_type definition and examples to documentation.
24004a7 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
make room_type definition in documentation more specific.
453321a 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
remove old changelog file.
8cc95ae 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
refactored changelog file to features, and made various updates to de…
13e015a 
…finitions and code per PR comments.

Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh @anoadragon453
Update docs/admin_api/rooms.md
01c97a9 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@anoadragon453
update the other room_type entry as well
2162421
@anoadragon453
Make use of the newly exposed room_type in _build_room_entry
7dd8b26
@anoadragon453
Revert "Make use of the newly exposed room_type in _build_room_entry"
3fca4c0 
This reverts commit 7dd8b26.
@andrewdoh
Merge remote-tracking branch 'upstream/develop' into develop
17d244d
@andrewdoh
Merge remote-tracking branch 'upstream/develop' into develop
f5cff52
@andrewdoh
Change joined_member endpoint to return NotImplementedError -> Synaps…
25b3b04 
…eError when trying to obtain joined_members after having left the room.

Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh
Merge remote-tracking branch 'upstream/develop' into develop
05fc5e7
@andrewdoh andrewdoh requested a review from a team as a code owner July 24, 2022 10:16
@andrewdoh
add changelog file for PR 13374.
ba10ef5 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@andrewdoh andrewdoh mentioned this pull request Jul 24, 2022
Closed
@andrewdoh
add type annotation for test function.
c9bb0db 
Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@babolivier babolivier self-assigned this Jul 25, 2022
babolivier
babolivier suggested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I've noted a few things that I think need changing but overall it looks pretty good to me!

changelog.d/13374.bugfix Outdated Show resolved Hide resolved
tests/rest/admin/test_room.py Outdated Show resolved Hide resolved
tests/rest/admin/test_room.py Outdated Show resolved Hide resolved
synapse/handlers/message.py Outdated Show resolved Hide resolved
andrewdoh and others added 2 commits July 25, 2022 09:36
@andrewdoh @babolivier
Update tests/rest/admin/test_room.py
cc8ac71 
Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
@andrewdoh @babolivier
Update changelog.d/13374.bugfix
02f0681 
Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
andrewdoh and others added 2 commits July 25, 2022 09:36
@andrewdoh @babolivier
Update tests/rest/admin/test_room.py
7248f39 
Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
@andrewdoh
update per feedback. made error message returned more descriptive and…
b2f418d 
… correct.

Signed-off-by: Andrew Doh <andrewddo@gmail.com>
@DMRobertson DMRobertson mentioned this pull request Jul 25, 2022
Merged
babolivier
babolivier approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@babolivier babolivier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay - thanks for your contribution!

@babolivier babolivier merged commit 78a3111 into matrix-org:develop Aug 3, 2022
azmeuk pushed a commit to azmeuk/synapse that referenced this pull request Aug 8, 2022
@andrewdoh @clokep
@anoadragon453 @babolivier @azmeuk
Return 404 or member list when getting joined_members after leaving (m…
d4e4a8e 
…atrix-org#13374)

Signed-off-by: Andrew Doh <andrewddo@gmail.com>
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: Andrew Morgan <andrewm@element.io>
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
Fizzadar added a commit to beeper/synapse-legacy-fork that referenced this pull request Aug 25, 2022
@Fizzadar
Merge tag 'v1.65.0' into beeper
84eef5b 
Synapse 1.65.0 (2022-08-16)
===========================

No significant changes since 1.65.0rc2.

Synapse 1.65.0rc2 (2022-08-11)
==============================

Internal Changes
----------------

- Revert 'Remove the unspecced `room_id` field in the `/hierarchy` response. ([\matrix-org#13365](matrix-org#13365))' to give more time for clients to update. ([\matrix-org#13501](matrix-org#13501))

Synapse 1.65.0rc1 (2022-08-09)
==============================

Features
--------

- Add support for stable prefixes for [MSC2285 (private read receipts)](matrix-org/matrix-spec-proposals#2285). ([\matrix-org#13273](matrix-org#13273))
- Add new unstable error codes `ORG.MATRIX.MSC3848.ALREADY_JOINED`, `ORG.MATRIX.MSC3848.NOT_JOINED`, and `ORG.MATRIX.MSC3848.INSUFFICIENT_POWER` described in [MSC3848](matrix-org/matrix-spec-proposals#3848). ([\matrix-org#13343](matrix-org#13343))
- Use stable prefixes for [MSC3827](matrix-org/matrix-spec-proposals#3827). ([\matrix-org#13370](matrix-org#13370))
- Add a new module API method to translate a room alias into a room ID. ([\matrix-org#13428](matrix-org#13428))
- Add a new module API method to create a room. ([\matrix-org#13429](matrix-org#13429))
- Add remote join capability to the module API's `update_room_membership` method (in a backwards compatible manner). ([\matrix-org#13441](matrix-org#13441))

Bugfixes
--------

- Update the version of the LDAP3 auth provider module included in the `matrixdotorg/synapse` DockerHub images and the Debian packages hosted on packages.matrix.org to 0.2.2. This version fixes a regression in the module. ([\matrix-org#13470](matrix-org#13470))
- Fix a bug introduced in Synapse v1.41.0 where the `/hierarchy` API returned non-standard information (a `room_id` field under each entry in `children_state`). ([\matrix-org#13365](matrix-org#13365))
- Fix a bug introduced in Synapse 0.24.0 that would respond with the wrong error status code to `/joined_members` requests when the requester is not a current member of the room. Contributed by @andrewdoh. ([\matrix-org#13374](matrix-org#13374))
- Fix bug in handling of typing events for appservices. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13392](matrix-org#13392))
- Fix a bug introduced in Synapse 1.57.0 where rooms listed in `exclude_rooms_from_sync` in the configuration file would not be properly excluded from incremental syncs. ([\matrix-org#13408](matrix-org#13408))
- Fix a bug in the experimental faster-room-joins support which could cause it to get stuck in an infinite loop. ([\matrix-org#13353](matrix-org#13353))
- Faster room joins: fix a bug which caused rejected events to become un-rejected during state syncing. ([\matrix-org#13413](matrix-org#13413))
- Faster room joins: fix error when running out of servers to sync partial state with, so that Synapse raises the intended error instead. ([\matrix-org#13432](matrix-org#13432))

Updates to the Docker image
---------------------------

- Make Docker images build on armv7 by installing cryptography dependencies in the 'requirements' stage. Contributed by Jasper Spaans. ([\matrix-org#13372](matrix-org#13372))

Improved Documentation
----------------------

- Update the 'registration tokens' page to acknowledge that the relevant MSC was merged into version 1.2 of the Matrix specification. Contributed by @moan0s. ([\matrix-org#11897](matrix-org#11897))
- Document which HTTP resources support gzip compression. ([\matrix-org#13221](matrix-org#13221))
- Add steps describing how to elevate an existing user to administrator by manipulating the database. ([\matrix-org#13230](matrix-org#13230))
- Fix wrong headline for `url_preview_accept_language` in documentation. ([\matrix-org#13437](matrix-org#13437))
- Remove redundant 'Contents' section from the Configuration Manual. Contributed by @dklimpel. ([\matrix-org#13438](matrix-org#13438))
- Update documentation for config setting `macaroon_secret_key`. ([\matrix-org#13443](matrix-org#13443))
- Update outdated information on `sso_mapping_providers` documentation. ([\matrix-org#13449](matrix-org#13449))
- Fix example code in module documentation of `password_auth_provider_callbacks`. ([\matrix-org#13450](matrix-org#13450))
- Make the configuration for the cache clearer. ([\matrix-org#13481](matrix-org#13481))

Internal Changes
----------------

- Extend the release script to automatically push a new SyTest branch, rather than having that be a manual process. ([\matrix-org#12978](matrix-org#12978))
- Make minor clarifications to the error messages given when we fail to join a room via any server. ([\matrix-org#13160](matrix-org#13160))
- Enable Complement CI tests in the 'latest deps' test run. ([\matrix-org#13213](matrix-org#13213))
- Fix long-standing bugged logic which was never hit in `get_pdu` asking every remote destination even after it finds an event. ([\matrix-org#13346](matrix-org#13346))
- Faster room joins: avoid blocking when pulling events with partially missing prev events. ([\matrix-org#13355](matrix-org#13355))
- Instrument `/messages` for understandable traces in Jaeger. ([\matrix-org#13368](matrix-org#13368))
- Remove an unused argument to `get_relations_for_event`. ([\matrix-org#13383](matrix-org#13383))
- Add a `merge-back` command to the release script, which automates merging the correct branches after a release. ([\matrix-org#13393](matrix-org#13393))
- Adding missing type hints to tests. ([\matrix-org#13397](matrix-org#13397))
- Faster Room Joins: don't leave a stuck room partial state flag if the join fails. ([\matrix-org#13403](matrix-org#13403))
- Refactor `_resolve_state_at_missing_prevs` to compute an `EventContext` instead. ([\matrix-org#13404](matrix-org#13404), [\matrix-org#13431](matrix-org#13431))
- Faster Room Joins: prevent Synapse from answering federated join requests for a room which it has not fully joined yet. ([\matrix-org#13416](matrix-org#13416))
- Re-enable running Complement tests against Synapse with workers. ([\matrix-org#13420](matrix-org#13420))
- Prevent unnecessary lookups to any external `get_event` cache. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13435](matrix-org#13435))
- Add some tracing to give more insight into local room joins. ([\matrix-org#13439](matrix-org#13439))
- Rename class `RateLimitConfig` to `RatelimitSettings` and `FederationRateLimitConfig` to `FederationRatelimitSettings`. ([\matrix-org#13442](matrix-org#13442))
- Add some comments about how event push actions are stored. ([\matrix-org#13445](matrix-org#13445), [\matrix-org#13455](matrix-org#13455))
- Improve rebuild speed for the "synapse-workers" docker image. ([\matrix-org#13447](matrix-org#13447))
- Fix `@tag_args` being off-by-one with the arguments when tagging a span (tracing). ([\matrix-org#13452](matrix-org#13452))
- Update type of `EventContext.rejected`. ([\matrix-org#13460](matrix-org#13460))
- Use literals in place of `HTTPStatus` constants in tests. ([\matrix-org#13463](matrix-org#13463), [\matrix-org#13469](matrix-org#13469))
- Correct a misnamed argument in state res v2 internals. ([\matrix-org#13467](matrix-org#13467))
@DMRobertson DMRobertson linked an issue Apr 21, 2023 that may be closed by this pull request
Return an appropriate response when getting joined_members after leaving #2851
Closed
@DMRobertson
Copy link
Contributor

The PR title is

Return 404 or member list when getting joined_members after leaving

But looking at the source this seems to only ever return 403 in this situation?

@DMRobertson DMRobertson changed the title Return 404 or member list when getting joined_members after leaving Return 403 when GETing /joined_members after leaving Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@babolivier babolivier babolivier approved these changes

@DMRobertson DMRobertson Awaiting requested review from DMRobertson

Assignees

@babolivier babolivier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return an appropriate response when getting joined_members after leaving
5 participants
@andrewdoh @DMRobertson @babolivier @clokep @anoadragon453