Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Comment about a better future where we can get the state diff between two events #13586

Merged
merged 4 commits into from
Aug 24, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13586.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Comment about a better future where we can get the state diff between two events.
6 changes: 6 additions & 0 deletions synapse/handlers/federation_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,12 @@ async def _get_state_ids_after_missing_prev_event(
InvalidResponseError: if the remote homeserver's response contains fields
of the wrong type.
"""

# It would be better if we could query the difference from our known
# state to the given `event_id` so the sending server doesn't have to
# send as much and we don't have to process as many events. For example
# in a room like #matrixhq, we get 200k events (77k state_events, 122k
MadLittleMods marked this conversation as resolved.
Show resolved Hide resolved
# auth_events) from this call.
MadLittleMods marked this conversation as resolved.
Show resolved Hide resolved
(
state_event_ids,
auth_event_ids,
Expand Down