Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Speed up @cachedList #13591

Merged
merged 10 commits into from
Aug 23, 2022
Merged

Speed up @cachedList #13591

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9f94106
Refactor DeferredCache
erikjohnston Aug 22, 2022
4456134
Bulk set API.
erikjohnston Aug 22, 2022
1626c62
Add bulk lookup API to DeferredCache.
erikjohnston Aug 22, 2022
ab035d2
Newsfile
erikjohnston Aug 23, 2022
7f3b52b
Rename get_callbacks
erikjohnston Aug 23, 2022
4222bfa
Rename _set_completed_callback
erikjohnston Aug 23, 2022
45ab2f1
fixup! Rename get_callbacks
erikjohnston Aug 23, 2022
486b0b1
Rename set_bulk
erikjohnston Aug 23, 2022
8731fd6
Merge branch 'develop' into erikj/cached_list_speed
erikjohnston Aug 23, 2022
6913f4c
Fix method missed during rename
erikjohnston Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13591.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve performance of `@cachedList`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress @erikjohnston 🎉

Here are the before/after timings for this PR using the have_seen_events benchmark from #13561

# events Before After
50k . 
Benchmark time (1 cold cache ): 3.7170820236206055
Benchmark time (2, warm cache): 0.2985079288482666
Benchmark time (3, warm cache): 0.28847789764404297
Benchmark time (4, odds      ): 0.1537461280822754
Benchmark time (5, odds      ): 0.14780497550964355
Benchmark time (6, evens     ): 0.1475691795349121
Benchmark time (7, evens     ): 0.14868617057800293
 . 
Benchmark time (1 cold cache ): 1.062384843826294
Benchmark time (2, warm cache): 0.18310809135437012
Benchmark time (3, warm cache): 0.17781400680541992
Benchmark time (4, odds      ): 0.09939789772033691
Benchmark time (5, odds      ): 0.09195113182067871
Benchmark time (6, evens     ): 0.08882665634155273
Benchmark time (7, evens     ): 0.08661413192749023
100k . 
Benchmark time (1 cold cache ): 8.10055136680603
Benchmark time (2, warm cache): 0.6121761798858643
Benchmark time (3, warm cache): 0.6093218326568604
Benchmark time (4, odds      ): 0.29950785636901855
Benchmark time (5, odds      ): 0.3049640655517578
Benchmark time (6, evens     ): 0.3025388717651367
Benchmark time (7, evens     ): 0.29833483695983887
 . 
Benchmark time (1 cold cache ): 2.264657735824585
Benchmark time (2, warm cache): 0.3539161682128906
Benchmark time (3, warm cache): 0.3556997776031494
Benchmark time (4, odds      ): 0.17580008506774902
Benchmark time (5, odds      ): 0.17888712882995605
Benchmark time (6, evens     ): 0.1756150722503662
Benchmark time (7, evens     ): 0.17418384552001953
200k . 
Benchmark time (1 cold cache ): 19.106724977493286
Benchmark time (2, warm cache): 22.98161005973816
Benchmark time (3, warm cache): 23.126408100128174
Benchmark time (4, odds      ): 11.401129007339478
Benchmark time (5, odds      ): 0.6159579753875732
Benchmark time (6, evens     ): 12.087002992630005
Benchmark time (7, evens     ): 0.6241748332977295
 . 
Benchmark time (1 cold cache ): 4.827088117599487
Benchmark time (2, warm cache): 4.958348035812378
Benchmark time (3, warm cache): 4.923892974853516
Benchmark time (4, odds      ): 2.5139119625091553
Benchmark time (5, odds      ): 0.3530576229095459
Benchmark time (6, evens     ): 2.465486764907837
Benchmark time (7, evens     ): 0.3511021137237549

Loading