Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix access token leak to logs from proxyagent #13855

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Fix access token leak to logs from proxyagent #13855

merged 5 commits into from
Sep 23, 2022

Commits on Sep 20, 2022

  1. Fix access token leak to logs from proxyagent 

    Saw that an example leak in
#13423 (comment)

```
2022-08-04 14:47:57,925 - synapse.http.client - 401 - DEBUG - as-sender-signal-1 - Sending request PUT http://localhost:29328/transactions/10722?access_token=<redacted>
2022-08-04 14:47:57,926 - synapse.http.proxyagent - 223 - DEBUG - as-sender-signal-1 - Requesting b'http://localhost:29328/transactions/10722?access_token=leaked' via <HostnameEndpoint localhost:29328>
```
    @MadLittleMods
    MadLittleMods committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    a5eb7f9 View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @MadLittleMods
    MadLittleMods committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    e854abb View commit details
    Browse the repository at this point in the history

  3. Convert bytes to string

    @MadLittleMods
    MadLittleMods committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    4254c20 View commit details
    Browse the repository at this point in the history

  4. Decode in a way that doesn't fail 

    See #13855 (comment)

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @MadLittleMods @clokep
    MadLittleMods and clokep authored Sep 20, 2022
    Configuration menu
    Copy the full SHA
    0b3cda0 View commit details
    Browse the repository at this point in the history

  5. Fix lints

    @MadLittleMods
    MadLittleMods committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    84b4afc View commit details
    Browse the repository at this point in the history