Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix mypy errors with latest canonicaljson #13905

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Fix mypy errors with latest canonicaljson #13905

merged 3 commits into from
Sep 26, 2022

Commits on Sep 26, 2022

  1. Lockfile: update canonicaljson 1.6.0 -> 1.6.3

    David Robertson committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    d6ee0a5 View commit details
    Browse the repository at this point in the history

  2. Fix mypy errors with latest canonicaljson 

    The change to `_encode_json_bytes` definition wasn't sufficient:

```
synapse/http/server.py:751: error: Incompatible types in assignment (expression has type "Callable[[Arg(object, 'json_object')], bytes]", variable has type "Callable[[Arg(object, 'data')], bytes]")  [assignment]
```

Which I think is mypy warning us that the two functions accept different
sets of kwargs. Fair enough!
    David Robertson committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    acfffcf View commit details
    Browse the repository at this point in the history

  3. Changelog

    David Robertson committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2b4f03a View commit details
    Browse the repository at this point in the history