This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix incorrectly sending authentication tokens to application service as headers #14301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
approved these changes
Oct 26, 2022
|
to the release branch please |
DMRobertson
force-pushed
the
dmr/fix-as-headers
branch
from
df03922
to
1960c0b
Compare
reivilibre
added
the
X-Regression
DMRobertson
pushed a commit
that referenced
this pull request
Oct 26, 2022
to detect the problem that #14301 fixed.
DMRobertson
pushed a commit
that referenced
this pull request
Oct 26, 2022
to detect the problem that #14301 fixed.
DMRobertson
pushed a commit
that referenced
this pull request
Oct 26, 2022
to detect the problem that #14301 fixed.
DMRobertson
pushed a commit
that referenced
this pull request
Oct 26, 2022
to detect the problem that #14301 fixed.
chagai95
pushed a commit
to chagai95/synapse
that referenced
this pull request
Nov 5, 2022
Synapse 1.70.1 (2022-10-28) =========================== Bugfixes -------- - Fix a bug introduced in Synapse 1.70.0rc1 where the access tokens sent to application services as headers were malformed. Application services which were obtaining access tokens from query parameters were not affected. ([\matrix-org#14301](matrix-org#14301)) - Fix room creation being rate limited too aggressively since Synapse v1.69.0. ([\matrix-org#14314](matrix-org#14314))
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #13996 in 1.70.0rc1.
I would like to do a follow-up patch which improves the typehinting to catch this at lint-time.