Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Handle malformed values of notification.room in power level events #14942

Merged
merged 7 commits into from
Jan 30, 2023
Merged

Handle malformed values of notification.room in power level events #14942

merged 7 commits into from
Jan 30, 2023

Commits on Jan 30, 2023

  1. Better test for bad values in power levels events 

    The previous test only checked that Synapse didn't raise an exception,
but didn't check that we had correctly interpreted the value of the
dodgy power level.

It also conflated two things: bad room notification levels, and bad user
levels. There _is_ logic for converting the latter to integers, but we
should test it separately.
    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2452122 View commit details
    Browse the repository at this point in the history

  2. Check we ignore types that don't convert to int

    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    37971fa View commit details
    Browse the repository at this point in the history

  3. Handle None values in notifications.room

    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e194241 View commit details
    Browse the repository at this point in the history

  4. Changelog

    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    289983c View commit details
    Browse the repository at this point in the history

  5. Also test that bad values are rejected by event auth

    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    698c288 View commit details
    Browse the repository at this point in the history

  6. Docstring

    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    6d82084 View commit details
    Browse the repository at this point in the history

  7. linter scripttttttttt

    David Robertson committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7b9faea View commit details
    Browse the repository at this point in the history