This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix TLS in the federation outbound proxy #15886
Closed
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TLS in the federation outbound proxy
Same fix as #15746
Thanks to @realtyem for pointing it out!
creatorForNetloc(...)
doesn't come with typing and expectshost
to bebytes
instead of astr
. It would be nice to add typing somehow so we don't keep running into this foot-gunProxyAgent
was introduced with the federation outbound proxy: #15773(this is wholly untested)
Pull Request Checklist
Pull request includes a sign off(run the linters)