Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add dict instance check before accessing it #15944

Closed
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/15944.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add dic instance check before accessing auth session.
2 changes: 1 addition & 1 deletion synapse/handlers/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ async def check_ui_auth(

sid: Optional[str] = None
authdict = clientdict.pop("auth", {})
if "session" in authdict:
if isinstance(authdict, dict) and "session" in authdict:
sid = authdict["session"]

# Convert the URI and method to strings.
Expand Down