This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Presence fix for idle mode #15989
Closed
Closed
Presence fix for idle mode #15989
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d6a6dff
Fix last_active_ts bug where ONLINE would always force an update to l…
realtyem 9f2fa60
Add test for checking online->online doesn't change last_active_ts
realtyem b4e3987
Fix race between send_user_sync() and send_stop_syncing(), which was …
realtyem f350e01
Fix UNAVAILABLE not staying set and causing a flicker to be sent out …
realtyem dc8cbdd
Add test for idle->idle from sync
realtyem bf71e78
changelog
realtyem 6b7e273
Combine the condition checking previous state to new state so that la…
realtyem 183e5f5
Revert "Combine the condition checking previous state to new state so…
realtyem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit hacky -- can we avoid trying to update in this case at all instead backtracking from saying we're online to unavailable?