This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use Python 3.12 for asyncio CI #16685
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying using uvloop has (fairly predictably) had no effect. |
clokep
reviewed
Dec 4, 2023
| @@ -226,6 +226,8 @@ pydantic = ">=1.7.4, <3" | |||
| # needed. | |||
| setuptools_rust = ">=1.3" | |||
|
|
|||
| uvloop = ">=0.19.0" | |||
There was a problem hiding this comment.
Note that the reactor tick timing stuff won't work with uvloop. I think I tried to support it briefly and then decided we probably weren't going to use it...
There was a problem hiding this comment.
Useful context! Was mainly wondering if using a different event loop would change how fast it'd run, but alas not. I guess there is just some extra overhead maybe?
There was a problem hiding this comment.
I think the asyncio reactor you end up doing some bookkeeping twice, which is annoying. I'm kind of surprised it is that much of a difference though, I wish we had a good benchmark for running this through instead of sytest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully to make it faster?