Bump Twisted Dependency to 17.1.0 #1909
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
btw, debian doesn't have twisted 17. |
|
Thanks! I had missed a new Twisted version was out.
This is going to be a nuisance. Since a bunch of the debian/ubuntu system packages depend on twisted, I'm loathed to manually package and/or backport twisted 17 in case it breaks things. I'll have a think about the best way to move forwards on this, perhaps by simply requiring Twisted 17 for pip installs but not debian installs. |
does new version always means improvements? how long twisted developers support older versions?
stretch (next stable) is in freeze and with v16, same in sid (unstable). maybe Debian Python Modules Team will package v17 after stretch release in testing/unstable and backport it for stable... who knows. but untill then I really hope that I and other Debian purists don't have to mess with pip, virtualenvs etc. also when synapse is released as package (in b4 docker), it's easier to set up, manage and upgrade. pips, dockers and other magic just adds unnecessary layer of complexity. YMMV. and "bleeding edge" is just stupid reason for upgrading things. of course, nobody have to listen crumpy sysadmins or BOFHs :> |
|
the point here is that if you want ipv6 to work fully you have to use 17.1.0 or later. we're not bumping for the hell of it
|
|
nobody is really using ipv6, not even github :> ok, sorry for noise, didn't pay attention because in #1002 (comment) he said "error was because of incorrect reverse proxy setup, not IPv6". so I misunderstood. anyway, there was someone who said he is going to package synapse for Debian propely... |
|
It's impossible to get synapse to work with a dual stack server without 17.
The only "solution" is to disable IPv6 entirely on the server, which is not
a solution at all in my book. The dependency needs to be changed for a big
reason, not just because "it's cool".
…On Feb 13, 2017 1:49 PM, "Ander Punnar" ***@***.***> wrote:
nobody is really using ipv6, not even github :>
ok, sorry for noise, didn't pay attention because in #1002 (comment)
<#1002 (comment)>
he said "error was because of incorrect reverse proxy setup, not IPv6". so
I misunderstood.
anyway, there was someone who said he is going to package synapse for
Debian propely...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1909 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFtT5m2_DaumHXyoZKs66dbG4v89lM_oks5rcLMZgaJpZM4L-i4B>
.
|
|
@erikjohnston is there something blocking merging this? |
|
Bumping twisted dependencies will prevent us from packaging synapse for most versions of debian/ubuntu. New versions of synapse that use pip will install Twisted 17 by default now. |
|
Sounds like we don't want to do this. Sure if you want proper IPv6 support you'll need Twisted 17.1, but we don't want to insist on that, or we'll break compatibility with all of the distros. A better solution might be to call out the need for 17.1 in the readme, as well as suggesting that people upgrade it in the changelog? |
|
As long as it's mentioned somewhere, I had a really hard time figuring out
why I couldn't get federation to work on my server.
…On Mar 31, 2017 8:34 AM, "Erik Johnston" ***@***.***> wrote:
Closed #1909 <#1909>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1909 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFtT5ltl2csHntWTWusyLStIu1bpgywRks5rrQDRgaJpZM4L-i4B>
.
|
|
new PR filed in #2088 |
This solves #1002
I've tested it with the new bump and doesn't appear to break anything. It fixes the IPv6 name resolution error, so federations now work with IPv6 homeservers (or dual-stack, like mine).