Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

m.read_marker -> m.fully_read #2128

Merged
merged 3 commits into from
Apr 18, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions synapse/handlers/read_marker.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,22 @@ def received_client_read_marker(self, room_id, user_id, event_id):
with (yield self.read_marker_linearizer.queue((room_id, user_id))):
account_data = yield self.store.get_account_data_for_room(user_id, room_id)

existing_read_marker = account_data.get("m.read_marker", None)
existing_read_marker = account_data.get("m.read_up_to", None)

should_update = True

if existing_read_marker:
# Only update if the new marker is ahead in the stream
should_update = yield self.store.is_event_after(
event_id,
existing_read_marker['marker']
existing_read_marker['event_id']
)

if should_update:
content = {
"marker": event_id
"event_id": event_id
}
max_id = yield self.store.add_account_data_to_room(
user_id, room_id, "m.read_marker", content
user_id, room_id, "m.read_up_to", content
)
self.notifier.on_new_event("account_data_key", max_id, users=[user_id])
4 changes: 2 additions & 2 deletions synapse/rest/client/v2_alpha/read_marker.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@


class ReadMarkerRestServlet(RestServlet):
PATTERNS = client_v2_patterns("/rooms/(?P<room_id>[^/]*)/read_marker$")
PATTERNS = client_v2_patterns("/rooms/(?P<room_id>[^/]*)/read_markers$")

def __init__(self, hs):
super(ReadMarkerRestServlet, self).__init__()
Expand All @@ -51,7 +51,7 @@ def on_POST(self, request, room_id):
event_id=read_event_id
)

read_marker_event_id = body.get("m.read_marker", None)
read_marker_event_id = body.get("m.read_up_to", None)
if read_marker_event_id:
yield self.read_marker_handler.received_client_read_marker(
room_id,
Expand Down