This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow upgrading a room only once #5045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5045 +/- ##
===========================================
- Coverage 61.57% 61.55% -0.02%
===========================================
Files 332 332
Lines 34265 34275 +10
Branches 5648 5650 +2
===========================================
+ Hits 21097 21098 +1
- Misses 11654 11660 +6
- Partials 1514 1517 +3 |
| defer.returnValue(None) | ||
|
|
||
| # Retrieve the room's tombstone event and return | ||
| tombstone_event = yield self.get_event(tombstone_id) |
There was a problem hiding this comment.
This will raise an exception if the event has been redacted. We probably want to allow an upgrade if the tombstone is redacted? idk
|
Superseded by #5051 due to discussion in #4583 (comment). |
anoadragon453
added a commit
that referenced
this pull request
Jun 25, 2019
Closes #4583 Does slightly less than #5045, which prevented a room from being upgraded multiple times, one after another. This PR still allows that, but just prevents two from happening at the same time. Mostly just to mitigate the fact that servers are slow and it can take a moment for the room upgrade to actually complete. We don't want people sending another request to upgrade the room when really they just thought the first didn't go through.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a room from being upgraded more than once, and also prevents a room upgrade for a room if one is currently ongoing. Returns a
400with the message "This room has already been upgraded" in either case.Fixes #4583