Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement room v5 which enforces signing key validity #5354

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Implement room v5 which enforces signing key validity #5354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/5354.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add a new room version where the timestamps on events are checked against the validity periods on signing keys.

10 changes: 5 additions & 5 deletions synapse/api/room_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ class RoomVersions(object):
StateResolutionVersions.V2,
enforce_key_validity=False,
)
VDH_TEST_KEY_VALIDITY = RoomVersion(
"vdh-test-key-validity",
RoomDisposition.UNSTABLE,
V5 = RoomVersion(
"5",
RoomDisposition.STABLE,
EventFormatVersions.V3,
StateResolutionVersions.V2,
enforce_key_validity=False,
enforce_key_validity=True,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a fail in #5348: https://github.com/matrix-org/synapse/pull/5348/files#r290665308

)


Expand All @@ -97,6 +97,6 @@ class RoomVersions(object):
RoomVersions.V2,
RoomVersions.V3,
RoomVersions.V4,
RoomVersions.VDH_TEST_KEY_VALIDITY,
RoomVersions.V5,
)
} # type: dict[str, RoomVersion]