This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Port "Fix 3PID invite room state over federation" to dinsic #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this file is reproduced on dockerhub and relative paths don't work
Fixes that when a user exchanges a 3PID invite for a proper invite over federation it does not include the `invite_room_state` key. This was due to synapse incorrectly sending out two invite requests.
Codecov Report
@@ Coverage Diff @@
## dinsic #5471 +/- ##
=========================================
Coverage ? 63.08%
=========================================
Files ? 326
Lines ? 35665
Branches ? 5852
=========================================
Hits ? 22500
Misses ? 11587
Partials ? 1578 |
babolivier
force-pushed
the
erikj/3pid_remote_invite_state
branch
from
1391578
to
3c9bb86
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #5464 to the
dinsicbranch