This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cleanups and sanity-checking in cpu and db metrics #5499
Merged
Commits on Jun 19, 2019
-
Remove unused _get_event_counters
This has been redundant since cdb3757.
-
Simplify PerformanceCounters.update interface
we already have the duration for the update, so may as well use it rather than passing extra params around and recalculating it.
-
Sanity-checking for metrics updates
Check that our clocks go forward.
Commits on Jun 24, 2019
-
-
Avoid raising exceptions in metrics
Sentry will catch the errors if they happen, so that should be good enough, and woun't make things explode if we hit the error condition.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.