Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't update the ratelimiter before sending a 3PID invite #5576

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Don't update the ratelimiter before sending a 3PID invite #5576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01d0f8e
Don't update the ratelimiter before sending a 3PID invite
babolivier Jun 28, 2019
b339f64
Changelog
babolivier Jun 28, 2019
15d9fc3
Only ratelimit when sending the email
babolivier Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5576.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug that would cause invited users to receive several emails for a single 3PID invite in case the inviter is rate limited.
1 change: 1 addition & 0 deletions synapse/handlers/room_member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,7 @@ def _make_and_store_3pid_invite(
"sender": user.to_string(),
"state_key": token,
},
ratelimit=False,
txn_id=txn_id,
)

Expand Down