Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Statistics-based Room Directory Queries #5947

Closed
wants to merge 8 commits into from
Closed

Statistics-based Room Directory Queries #5947

wants to merge 8 commits into from

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Aug 30, 2019 •
edited
Loading

Note:

  • Does not use full text search — but neither does current solution, so broadly speaking no worse.
  • Does not enforce a 60 second timeout — I will try to address this now if possible.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off

@reivilibre
Use room_stats and room_state for room directory search
d5cc8b3 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Don't populate empty/null fields in publicRooms.
295b1de 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Select m.room.create event ID as a JOIN.
30d7bc2 
### Performance comparison

* Before
    * cold: 25 seconds
    * warm: 16 seconds
* After
    * cold: 13 seconds
    * warm: 11 seconds

Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Give a proper error for invalid pagination tokens.
b396297 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Use async/await syntax.
28c7421 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Adapt for new separated statistics.
a04f01e 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Newsfile
304bc2f 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@erikjohnston erikjohnston changed the base branch from develop to rei/rss_target August 30, 2019 16:29
@reivilibre reivilibre changed the base branch from rei/rss_target to develop August 30, 2019 16:32
@reivilibre reivilibre changed the base branch from develop to rei/rss_target August 30, 2019 16:32
@erikjohnston erikjohnston self-requested a review September 2, 2019 09:12
@richvdh
Copy link
Member

richvdh commented Sep 18, 2019

I'm not sure how this relates to #6019

@richvdh richvdh mentioned this pull request Sep 18, 2019
Closed
@richvdh
Copy link
Member

richvdh commented Oct 3, 2019

superceded by #6019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston Awaiting requested review from erikjohnston

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reivilibre @richvdh @erikjohnston