Fix public room list pagination. #6152

erikjohnston · 2019-10-02T14:11:31Z

We incorrectly used room_id as to bound the result set, even though we
order by joined_members, room_id, leading to incorrect results after
pagination.

We incorrectly used `room_id` as to bound the result set, even though we order by `joined_members, room_id`, leading to incorrect results after pagination.

babolivier

lgtm

erikjohnston added 2 commits October 2, 2019 15:11

Fix public room list pagination.

03cf438

We incorrectly used `room_id` as to bound the result set, even though we order by `joined_members, room_id`, leading to incorrect results after pagination.

Newsfile

8e32240

erikjohnston requested a review from a team October 2, 2019 14:13

erikjohnston mentioned this pull request Oct 2, 2019

Fix not showing non-federatable rooms to remote room list queries #6153

Merged

babolivier approved these changes Oct 2, 2019

View reviewed changes

erikjohnston merged commit 824df3e into develop Oct 2, 2019

erikjohnston deleted the erikj/fix_room_list branch January 9, 2020 15:48

babolivier pushed a commit that referenced this pull request Sep 1, 2021

Merge pull request #6152 from matrix-org/erikj/fix_room_list

9f7acf6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix public room list pagination. #6152

Fix public room list pagination. #6152

erikjohnston commented Oct 2, 2019

babolivier left a comment

Fix public room list pagination. #6152

Fix public room list pagination. #6152

Conversation

erikjohnston commented Oct 2, 2019

babolivier left a comment

Choose a reason for hiding this comment