This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Move persist_events out from main data store. #6240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for splitting out of state_groups_state from the main store into it own one, as persisting events depends on calculating state.
erikjohnston
force-pushed
the
erikj/split_out_persistence_store
branch
from
October 23, 2019 12:29
d008268
to
ab581c2
Compare
I'm currently fiddling to change the way we access the persistence store ftr |
erikjohnston
force-pushed
the
erikj/split_out_persistence_store
branch
from
October 23, 2019 15:16
ab581c2
to
9fb9688
Compare
So the plan is broadly that all the new storage classes get added to the |
This was referenced Oct 24, 2019
richvdh
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm, though it's not easy to see from the diff what's happening. A few requests for docstrings etc
richvdh
reviewed
Oct 29, 2019
…lit_out_persistence_store
erikjohnston
force-pushed
the
erikj/split_out_persistence_store
branch
from
October 30, 2019 13:37
a73963e
to
ec6de1c
Compare
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for splitting out of state_groups_state from the
main store into it own one, as persisting events depends on calculating
state.
Broadly I've just moved functions from the main data store up into an
EventPersistenceStore
and changed calls to storage functions toself.main_store.*
andself.state_store.*