Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix inaccurate per-block metrics #6491

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix inaccurate per-block metrics #6491

merged 1 commit into from
Dec 9, 2019

Commits on Dec 8, 2019

  1. Fix inaccurate per-block metrics

    `Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during *any* of those calls would be reported against *all* of them, producing wildly inaccurate results.
    
    Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).
    richvdh committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    c749bd0 View commit details
    Browse the repository at this point in the history