This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add delta file to fix missing default table data #6555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Dec 16, 2019
synapse/storage/data_stores/main/schema/delta/56/device_stream_id_insert.sql
Show resolved
Hide resolved
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '7963ca83c': Add delta file to fix missing default table data (#6555)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6311
The above issue came about because we missed an INSERT statement when making the 56 full schema. Synapse expected that row to exist, and had an UPDATE statement for it. When we missed the INSERT, the UPDATE just failed silently.
#6363 fixed it by doing some INSERT/UPDATE stuff in python, but it's not efficient and is prone to race conditions. This PR reverts that commit, and instead just adds another delta file, which is a cleaner fix.
Reverts #6363