Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove duplicate session check in web fallback servlet #6702

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Remove duplicate session check in web fallback servlet #6702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef0157
Remove duplicate session check
anoadragon453 Jan 14, 2020
58f7b8b
Add changelog
anoadragon453 Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6702.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove duplicate check for the `session` query parameter on the `/auth/xxx/fallback/web` Client-Server endpoint.
4 changes: 0 additions & 4 deletions synapse/rest/client/v2_alpha/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,6 @@ async def on_POST(self, request, stagetype):

return None
elif stagetype == LoginType.TERMS:
if ("session" not in request.args or len(request.args["session"])) == 0:
raise SynapseError(400, "No session supplied")

session = request.args["session"][0]
authdict = {"session": session}

success = await self.auth_handler.add_oob_auth(
Expand Down