Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Persist user interactive authentication sessions #7302

Merged
merged 36 commits into from
Apr 30, 2020
Merged

Persist user interactive authentication sessions #7302

merged 36 commits into from
Apr 30, 2020

Commits on Apr 22, 2020

  1. Persist the storage of UI Auth sessions into the database.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    b030fdb View commit details
    Browse the repository at this point in the history

  2. Ensure that UI auth stages are idempotent.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    4a83da9 View commit details
    Browse the repository at this point in the history

  3. Fix postgresql issues.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    e7a2db6 View commit details
    Browse the repository at this point in the history

  4. Add a changelog file.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    b9dd110 View commit details
    Browse the repository at this point in the history

  5. Expire old sessions.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    831f8a2 View commit details
    Browse the repository at this point in the history

  6. Keep the last_used time up-to-date.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    04d3d8b View commit details
    Browse the repository at this point in the history

  7. Properly run the looping call in the background.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    0fdb22c View commit details
    Browse the repository at this point in the history

  8. Properly call get_session as async.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3d9b3a8 View commit details
    Browse the repository at this point in the history

  9. Attempt to avoid clashes in session IDs.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    b5fc1b9 View commit details
    Browse the repository at this point in the history

  10. Properly await runInteraction calls.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    d9157c4 View commit details
    Browse the repository at this point in the history

  11. Add the UIAuthStore to workers.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    ae45238 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary lambda 

    Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @clokep @richvdh
    clokep and richvdh committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9ac9c54 View commit details
    Browse the repository at this point in the history

  13. Only expire old sessions on the master.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    1c861b8 View commit details
    Browse the repository at this point in the history

  14. Match the looping_call signature in unit tests.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    0895971 View commit details
    Browse the repository at this point in the history

  15. Fix mypy typing and run mypy on the new file.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    42c4bca View commit details
    Browse the repository at this point in the history

  16. Add a few return types.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2d1bcad View commit details
    Browse the repository at this point in the history

  17. Prefix a number to the delta file.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f2e5151 View commit details
    Browse the repository at this point in the history

  18. Clarify comments.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    7091341 View commit details
    Browse the repository at this point in the history

  19. Rename methods based on feedback.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    ff14b66 View commit details
    Browse the repository at this point in the history

  20. Avoid re-doing work.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2a4a910 View commit details
    Browse the repository at this point in the history

  21. Use JsonDict in some places.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    5a60f2d View commit details
    Browse the repository at this point in the history

  22. Create a return type for UI auth session data.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    6b4a6df View commit details
    Browse the repository at this point in the history

  23. Ensure the session exists before marking a stage complete.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    1a5101b View commit details
    Browse the repository at this point in the history

  24. Use creation time instead of last updated time.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    264ef03 View commit details
    Browse the repository at this point in the history

  25. Rename the identity parameter to result.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    8b5ef4a View commit details
    Browse the repository at this point in the history

  26. Separate the unsafe worker methods to a separate object.

    @clokep
    clokep committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f179c21 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Use _txn in method names.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    64c709b View commit details
    Browse the repository at this point in the history

  2. Document possible error states better.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    568a778 View commit details
    Browse the repository at this point in the history

  3. Review feedback.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    79c5be5 View commit details
    Browse the repository at this point in the history

  4. Do not directly raise SynapseError.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    18b3494 View commit details
    Browse the repository at this point in the history

  5. Use foreign keys to simplify logic.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    5340662 View commit details
    Browse the repository at this point in the history

  6. Again fix idempotency of the registration API.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    5f0bf19 View commit details
    Browse the repository at this point in the history

  7. Fix lint.

    @clokep
    clokep committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    eccb670 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Fix typo in docstring. 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @clokep @richvdh
    clokep and richvdh committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    106dca9 View commit details
    Browse the repository at this point in the history

  2. Raise a 400 error, not 404.

    @clokep
    clokep committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    64852bf View commit details
    Browse the repository at this point in the history

  3. Convert StoreErrors to SynapseErrors.

    @clokep
    clokep committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    ae27afd View commit details
    Browse the repository at this point in the history