This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Bump dh-virtualenv and build for focal #7526
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Update the version of dh-virtualenv we use to build debs, and add focal to the list of target distributions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,15 +27,16 @@ RUN env DEBIAN_FRONTEND=noninteractive apt-get install \ | |
wget | ||
|
||
# fetch and unpack the package | ||
RUN wget -q -O /dh-virtuenv-1.1.tar.gz https://github.com/spotify/dh-virtualenv/archive/1.1.tar.gz | ||
RUN tar xvf /dh-virtuenv-1.1.tar.gz | ||
RUN mkdir /dh-virtualenv | ||
RUN wget -q -O /dh-virtualenv.tar.gz https://github.com/matrix-org/dh-virtualenv/archive/matrixorg-20200519.tar.gz | ||
RUN tar -xv --strip-components=1 -C /dh-virtualenv -f /dh-virtualenv.tar.gz | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. --strip-components ensures that we end up with a directoryy called |
||
|
||
# install its build deps | ||
RUN cd dh-virtualenv-1.1/ \ | ||
&& env DEBIAN_FRONTEND=noninteractive mk-build-deps -ri -t "apt-get -yqq --no-install-recommends" | ||
RUN cd /dh-virtualenv \ | ||
&& env DEBIAN_FRONTEND=noninteractive mk-build-deps -ri -t "apt-get -y --no-install-recommends" | ||
|
||
# build it | ||
RUN cd dh-virtualenv-1.1 && dpkg-buildpackage -us -uc -b | ||
RUN cd /dh-virtualenv && dpkg-buildpackage -us -uc -b | ||
|
||
### | ||
### Stage 1 | ||
|
@@ -68,12 +69,12 @@ RUN apt-get update -qq -o Acquire::Languages=none \ | |
sqlite3 \ | ||
libpq-dev | ||
|
||
COPY --from=builder /dh-virtualenv_1.1-1_all.deb / | ||
COPY --from=builder /dh-virtualenv_1.2~dev-1_all.deb / | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume this name changed because it is an autogenerated thing that dh-virtualenv spits out? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yesish. it's because of spotify/dh-virtualenv@2a37a73. |
||
|
||
# install dhvirtualenv. Update the apt cache again first, in case we got a | ||
# cached cache from docker the first time. | ||
RUN apt-get update -qq -o Acquire::Languages=none \ | ||
&& apt-get install -yq /dh-virtualenv_1.1-1_all.deb | ||
&& apt-get install -yq /dh-virtualenv_1.2~dev-1_all.deb | ||
|
||
WORKDIR /synapse/source | ||
ENTRYPOINT ["bash","/synapse/source/docker/build_debian.sh"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ DISTS = ( | |
"ubuntu:cosmic", | ||
"ubuntu:disco", | ||
"ubuntu:eoan", | ||
"ubuntu:focal", | ||
) | ||
|
||
DESC = '''\ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this turns out never to have done anything; as of recent dh_virtualenv it tries to do something, which is broken.