Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix bug in per-room message retention policies. #7850

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Fix bug in per-room message retention policies. #7850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
653dfab
Do not dump the event content back to a string.
clokep Jul 14, 2020
2f033c5
Improve changelog.
clokep Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7850.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix "AttributeError: 'str' object has no attribute 'get'" error message when applying per-room message retention policies. The bug was introduced in Synapse 1.7.0.
2 changes: 1 addition & 1 deletion synapse/storage/data_stores/main/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ def _background_insert_retention_txn(txn):
retention_policy = {}
else:
ev = json.loads(row["json"])
retention_policy = json.dumps(ev["content"])
retention_policy = ev["content"]

self.db.simple_insert_txn(
txn=txn,
Expand Down